641389 - [Collector] Detect Installed Add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect, P2)

Description

[Brian King [:kinger]]

Before adding an item to a collection, we need to determine if it is already installed to create a different type.

I think we can do a simple AOM query, and then we need to pass a different parameter (not remote) to the createItem call.

Comment 1

[David McNamara [:mackers]]

Fixed.

r85126

Comment 2

[Brian King [:kinger]]

Reopening - when a collection is refreshed, duplicates of local items are created.

Comment 3

[David McNamara [:mackers]]

(In reply to comment #2)
> Reopening - when a collection is refreshed, duplicates of local items are
> created.

Can't reproduce this. STR?

Comment 4

[Brian King [:kinger]]

(In reply to comment #3)
> Can't reproduce this. STR?

1. Load the Collections pane
2. Load a collection that has at least 1 add-on that is installed locally
3. Refresh all collections (wait for interval refresh or use manual button)

Comment 5

[Brian King [:kinger]]

Attachment: Double Entries

Screenshot showing double entries. Fotofox and Foxclocks (disabled) are installed locally.

Comment 6

[David McNamara [:mackers]]

Still can't repro.

Checked in a blind fix r85329

Comment 7

[Brian King [:kinger]]

(In reply to comment #6)
> Still can't repro.
> 
> Checked in a blind fix r85329

This caused another regression. Now the local add-on is not appearing in the Collection(s) it belongs to on first sync. On reload, it appears. On subsequent reloads, duplicates do not appear.

Comment 8

[David McNamara [:mackers]]

Arg. Another blind fix checked in. 

r85341

If that doesn't work, please try to debug yourself if you can still repro.

Offending code is:

collectionsPaneController.js:1076

Comment 9

[Brian King [:kinger]]

(In reply to comment #8)
> Arg. Another blind fix checked in. 

Yes, that did it! Thanks.