Closed Bug 641418 Opened 13 years ago Closed 13 years ago

Create a comm-2.0 branch in buildbot for SeaMonkey to follow mozilla-2.0

Categories

(SeaMonkey :: Release Engineering, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(1 file, 1 obsolete file)

This is to track the work necessary to create a SeaMonkey (comm-2.0) branch to follow mozilla-2.0

* Create SeaMonkey2.1 Tinderbox tree [done prior to this bug]
* Setup branch-tracking login in comm-central (See-Also Bug 639726)
* Buildbot Work (this bug)
* Update comm-central version to be 2.2a1pre when built off mozilla-central (will do in Bug 639726)



About this patch, I copied all mozconfigs in use on comm-central at the moment. I also suspect that the l10nbuilds.ini is actually used by the L10n magic automation stuff, so I did adjust that :-)

Also did not enable Blocklist Updates on comm-2.0 yet, (note blocklist magic script may pose problems here, will revisit this later, for now we'll keep updating, only once)
Attached patch v1 (obsolete) — Splinter Review
Please state, if r+ if this can land before 639726 or if we need that first.
Attachment #519070 - Flags: review?(kairo)
Attached patch v1.1Splinter Review
Noticed a minor mistake
Attachment #519070 - Attachment is obsolete: true
Attachment #519070 - Flags: review?(kairo)
Attachment #519071 - Flags: review?(kairo)
Actually let me ask....

Pike/Rail,

is l10nbuilds.ini used in any of your automation/tools as far as you know?
Or is it an ancient vestige of Buildbot-0.7 stuff?
AFAIK, this file is not used by 0.8 automation anymore.
The l10n dashboard automation doesn't share any code with buildbotcustom/-configs anymore, so it's not affected by this patch.
(In reply to comment #0)
> About this patch, I copied all mozconfigs in use on comm-central at the moment.

Hrm, we usually did symlinks for Linux and Mac for that, as long as the files didn't differ.
Oh, and as a side note, we need one additional bug in all this, and that's creating a suited l10n*.ini in suite/locales and have Axel create a sea22x in the dashboard, switching sea21x to the new ini that follows l10n-mozilla-2.0 (that's what FF4 desktop/mobile will use, AFAIK).
Comment on attachment 519071 [details] [diff] [review]
v1.1

>-BRANCHES['comm-central-trunk']['l10n_tree'] = 'sea21x'
>+BRANCHES['comm-central-trunk']['l10n_tree'] = 'sea22x'

Hmm, I wonder how well that works, but could be that is only refers to l10nbuilds.ini anyhow.

>+BRANCHES['comm-2.0']['start_hour'] = [0]
>+BRANCHES['comm-2.0']['start_minute'] = [30]

We should care that nightlies are triggers slightly apart - feel free to come up with good ideas on timing there. ;-)

>+l10n.ini = suite/locales/l10n.ini

Nope. Should be suite/locales/l10n-moz2.0.ini instead (see comm-central repo).


Regarding the mozconfig copies, you see how many files they are, and they can make maintenance difficult, but I'll leave that up to you. ;-)

r+ with the nits fixed.
Attachment #519071 - Flags: review?(kairo) → review+
Just pushed this live and reconfigured buildbotmaster, holding bug open until I can confirm nothing bad happened.
Followup with: http://hg.mozilla.org/build/buildbot-configs/rev/21983bb2e134

Also created the |seamonkey-production| branch with that checkin.

comm-2.0 is on buildbot, will need to ensure the tbpl is setup right.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
See Also: → 639726
(In reply to comment #10)
> will need to ensure the tbpl is setup right.

Did a push to fix, and filed Bug 641726 to get us there.
Depends on: 641745
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: