641745 - Update data.sql in graphserver for new SeaMonkey 2.1 Branch

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

Attachment: Add Them

This is to get reviews on the graph server stuff.

Diffed/patched against |1.0| branch, |default| is missing the data.sql and |production| appears unused at the moment.

If any of my assumptions here are wrong, feel free to tell me.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 519326 [details] [diff] [review]
Add Them

># HG changeset patch
>-insert into machines values (NULL,6,0,NULL,"Linux_comm-central-trunk",1,unix_timestamp());
>+insert into machines values (NULL,6,0,NULL,"Linux_comm-2.0",1,unix_timestamp());
>+insert into machines values (NULL,6,0,NULL,"Linux_comm-2.0_leak_test",1,unix_timestamp());insert into machines values (NULL,6,0,NULL,"Linux_comm-central-trunk",1,unix_timestamp());

I'm not comfortable with giving r+ in this area, but I can give an r- on this hunk

Comment 2

[Justin Wood (:Callek)]

Attachment: Add Them v1.1

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 519330 [details] [diff] [review]
Add Them v1.1

Requesting review from Bhearsum and catlee, as both have reviewed this file this month.

I'll take whoever can get here first. (Note these Boxes are already in production for seamonkey, the graph-server issue was an unfortunate oversight, so resolving this sooner than later is appreciated).

Comment 4

[[e-mail] (:bhearsum)]

Comment on attachment 519330 [details] [diff] [review]
Add Them v1.1

stamp

Comment 5

[Justin Wood (:Callek)]

Pushed as http://hg.mozilla.org/graphs/rev/40c10bdc4dd4 and filed Bug 642057 on deploying this.