64150 - prefs panel elements should be in tab order for prefs window

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P4)

Description

[Jesse Ruderman]

Current tab order in prefs:

[Nothing - bug 64052], category tree, ok, cancel.

Expected tab order:

Category tree, first focusable item on panel, ..., last focusable item on 
panel, ok, cancel.

This is the main bug preventing keyboard access to prefs.

Note that if you click on something in one of the prefs panels, you can tab 
around within that panel.

Also note that there's currently a bug where if you focus the category tree and 
then click on a focusable element in a panel, the tree doesn't /appear/ to lose 
focus.  If you're using modern and hover the mouse cursor over the green border 
around the active tree element, the tree then appears to suddenly lose focus.  
I can't find the bug, but it should probably be fixed along with this one.

Comment 1

[Viswanath Ramachandran]

nav triage: shd this be in the keyboard navigation component? cc mcafee. 

Comment 2

[Jesse Ruderman]

Blake said something about the pref pane and pref buttons being different 
documents in bug 65943; ccing him.

Comment 3

[Paul Chen]

nav triage team:

marking nsbeta1+

Comment 4

[Paul Chen]

nav triage team:

Putting on the backburner, removing nsbeta1+, marking p4 and future

Comment 5

[Chris McAfee]

keyboardnav

Comment 6

[sairuh (rarely reading bugmail)]

renominating for catfood, as this greatly impacts keyboard accessibility in this
dialog.

Comment 7

[Jesse Ruderman]

I can now get from the category tree to the prefs panel by pressing tab several 
times.  Shift+tab is still broken, initial focus is wrong, and the tab order 
isn't right, but it's now possible to get to any control in prefs using the 
keyboard.

Comment 8

[Aaron Leventhal]

I don't really understand this bug, because you can tab through the prefs panel,
but you occasionally lose any visualy indication of where the focus is. Pressing
tab a couple more times gets you somewhere.

However, at least on my Windows system, you can navigate the prefs with the
keyboard - sort of. You may miss a couple of elements.

Is there a specific bug where focus gets lost to lala land? Or is that this bug?

Comment 9

[Jesse Ruderman]

lala land = bug 64052, "prefs: some non-control is in the tab order between 
Cancel and panel items".

This bug should probably be marked worksforme, and new bugs should be filed for 
the remaining problems (tab order is wrong, shift+tab is broken, initial focus 
should be category tree).

Comment 10

[Chris McAfee]

over to vishy to find an owner

Comment 11

[Blake Ross]

bryner fixed this bug.

Comment 12

[sairuh (rarely reading bugmail)]

yep, this has been working for some time.