Open
Bug 641598
Opened 11 years ago
Updated 6 years ago
Regression from Firefox 3.6: onblur event handler fires after calling focus()
Categories
(Core :: DOM: Events, defect)
Tracking
()
NEW
People
(Reporter: imphil, Assigned: tnikkel)
References
(Blocks 2 open bugs)
Details
(Keywords: regression)
Attachments
(5 files)
2.08 KB,
text/html
|
Details | |
1.86 KB,
patch
|
Details | Diff | Splinter Review | |
10.21 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
12.22 KB,
patch
|
Details | Diff | Splinter Review | |
11.93 KB,
patch
|
Details | Diff | Splinter Review |
I experienced this problem on http://www.farnell.de and reduced it to the attached testcase. STR: 1. Load the testcase in Firefox 4 (I have here a nightly from 2011-03-14) 2. Move your mouse directly from the address bar to the input box and click in it Expected behavior: 3a. The text inside the input should go away and the cursor blink inside the textbox. Actual behavior: 3b. The gray text does not go away, the input field is not enabled. Entering text is not possible. Now, to make this a bit more interesting, move your mouse around on the page, e.g. over the "button" for a couple seconds and then click in the input box again. Now the input receives focus and text input is possible. Unfortunately, in this testcase I didn't find a 100% reproducible way to trigger to trigger the behavior that the input works again. On the original site however, it is more easily reproduced: 1. load http://farnell.de 2. from the address bar, go directly to the search input and click there: input does not become enabled. 3. mouseover the "Suchen" button 4. Now click into the search input: now it becomes active and it works as expected. Firefox 3.6 shows the expected behavior, as does Konqueror 4.6.
![]() |
||
Updated•11 years ago
|
Assignee: nobody → enndeakin
Keywords: regression
Updated•11 years ago
|
Keywords: regressionwindow-wanted
Reporter | ||
Comment 1•11 years ago
|
||
Regression window (down to a single day) OK: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010/10/2010-10-09-03-mozilla-central/firefox-4.0b8pre.en-US.linux-x86_64.tar.bz2 Built from http://hg.mozilla.org/mozilla-central/rev/d45c87e58110 NOK: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2010/10/2010-10-10-03-mozilla-central/firefox-4.0b8pre.en-US.linux-x86_64.tar.bz2 Built from http://hg.mozilla.org/mozilla-central/rev/26c47ba8064f
Assignee | ||
Comment 2•11 years ago
|
||
That corresponds to http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d45c87e58110&tochange=26c47ba8064f
Keywords: regressionwindow-wanted
![]() |
||
Comment 3•11 years ago
|
||
Perhaps from bug 591815?
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to comment #3) > Perhaps from bug 591815? Yep, verified by undoing that patch.
Blocks: 591815
Assignee | ||
Comment 5•11 years ago
|
||
The NS_MOUSE_BUTTON_DOWN case of nsEventStateManager::PostHandleEvent doesn't seem to sanely handle the case where mCurrentTarget, aTargetFrame, and mCurrentTargetContent are all null.
Assignee | ||
Comment 6•11 years ago
|
||
Specifically the case where nsEventStatus_eConsumeNoDefault != *aStatus.
Assignee | ||
Comment 7•11 years ago
|
||
Bug 591815 was only about the prevent default case, so maybe for this case we should make the processing conditional on having a target frame like it was before bug 591815?
Assignee | ||
Comment 8•11 years ago
|
||
Should we just do this?
Assignee | ||
Comment 9•11 years ago
|
||
Attachment #520060 -
Flags: review?(Olli.Pettay)
Comment 10•11 years ago
|
||
-w patch might make reviewing easier.
Assignee | ||
Comment 11•11 years ago
|
||
There is a -w patch: https://bugzilla.mozilla.org/attachment.cgi?id=520059
Comment 12•11 years ago
|
||
Oops, sorry, I somehow missed that comment.
Comment 13•11 years ago
|
||
Comment on attachment 520060 [details] [diff] [review] patch We really need some tests here. r=me if you add tests.
Attachment #520060 -
Flags: review?(Olli.Pettay) → review+
Assignee | ||
Updated•11 years ago
|
Assignee: enndeakin → tnikkel
Assignee | ||
Comment 14•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Whiteboard: [needs landing][needs a tryserver check]
Comment 15•11 years ago
|
||
Timothy, have you posted this to the try server?
Assignee | ||
Comment 16•11 years ago
|
||
I have not.
Comment 17•11 years ago
|
||
Looks like this causes a M1 timeout: <http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1303400192.1303403351.30016.gz>
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•11 years ago
|
Whiteboard: [needs landing][needs a tryserver check]
Assignee | ||
Comment 18•11 years ago
|
||
Thanks for sending that to try server.
Comment 19•11 years ago
|
||
Timothy, do you time to work on this?
Assignee | ||
Comment 20•11 years ago
|
||
Not at the moment, I was planning to come back to this, but if you want to pick it up feel free to do so.
Assignee | ||
Comment 21•10 years ago
|
||
Still fails ERROR TEST-UNEXPECTED-FAIL | /tests/content/events/test/test_bug534833.html | Test timed out.
You need to log in
before you can comment on or make changes to this bug.
Description
•