Closed
Bug 641621
Opened 14 years ago
Closed 14 years ago
incorrectly returning NPError value as nsresult in nsNPAPIPluginInstance::GetValueFromPlugin
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jaas, Assigned: jaas)
Details
Attachments
(1 file, 1 obsolete file)
|
12.26 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
nsNPAPIPluginInstance::GetValueFromPlugin
610 nsresult rv = NS_ERROR_FAILURE;
611 if (pluginFunctions->getvalue && RUNNING == mRunning) {
612 PluginDestructionGuard guard(this);
613
614 NS_TRY_SAFE_CALL_RETURN(rv, (*pluginFunctions->getvalue)(&mNPP, variable, value), this);
This is a minimal-impact patch, no required changes for callers. It does contain a fix for one caller with particularly bad code. We can do this in a better way once bug 637253 is fixed and we might want to take this as a ride-along for any Firefox 4 updates.
Comment on attachment 519260 [details] [diff] [review]
fix v1.0
This won't work, dumb mistake.
Attachment #519260 -
Attachment is obsolete: true
Attachment #519368 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #519368 -
Flags: review?(benjamin) → review+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/a200ce371570
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•