642227 - remove support for <pre variable>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We support the "variable" attribute on the HTML "pre" element, but no other browser (tested IE8, Chromium, Opera) does.  We should stop supporting it.

(Followup from bug 636039 comment 36.)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Should wait for bug 636039 to land so we don't conflict with it.  Past that, this is easy.

Ms2ger, feel free to steal if you want!

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, I already had a patch in my tree...

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 519924 [details] [diff] [review]
patch

I think you can remove the atom from nsGkAtomList as well.  r=me either way.

Can you add a reftest for this?

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'd rather not add a reftest -- I wouldn't want a test to fail if we decided we needed to add the feature back.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, and I can't remove the atom because of:
http://hg.mozilla.org/mozilla-central/file/b853c6efa929/content/base/src/nsDocumentEncoder.cpp#l1474

... although I suspect that's a mistake and should be using var.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/projects/birch/rev/7d15e6eff4df

Filed bug 642716 on fixing nsHTMLCopyEncoder.

Comment 9

[(no longer active)]

Can we get a reftest here which makes sure that <pre> and <pre variable> render the same way?  Small marginal value, but still...

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/7d15e6eff4df