Closed Bug 642227 Opened 9 years ago Closed 9 years ago

remove support for <pre variable>

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(2 files)

We support the "variable" attribute on the HTML "pre" element, but no other browser (tested IE8, Chromium, Opera) does.  We should stop supporting it.

(Followup from bug 636039 comment 36.)
Should wait for bug 636039 to land so we don't conflict with it.  Past that, this is easy.

Ms2ger, feel free to steal if you want!
Assignee: nobody → bzbarsky
Depends on: 636039
Priority: -- → P1
Oh, I already had a patch in my tree...
Assignee: bzbarsky → dbaron
Attached patch patchSplinter Review
Attachment #519924 - Flags: review?(bzbarsky)
Comment on attachment 519924 [details] [diff] [review]
patch

I think you can remove the atom from nsGkAtomList as well.  r=me either way.

Can you add a reftest for this?
Attachment #519924 - Flags: review?(bzbarsky) → review+
I'd rather not add a reftest -- I wouldn't want a test to fail if we decided we needed to add the feature back.
Oh, and I can't remove the atom because of:
http://hg.mozilla.org/mozilla-central/file/b853c6efa929/content/base/src/nsDocumentEncoder.cpp#l1474

... although I suspect that's a mistake and should be using var.
https://hg.mozilla.org/projects/birch/rev/7d15e6eff4df

Filed bug 642716 on fixing nsHTMLCopyEncoder.
Whiteboard: fixed-in-birch
Can we get a reftest here which makes sure that <pre> and <pre variable> render the same way?  Small marginal value, but still...
https://hg.mozilla.org/mozilla-central/rev/7d15e6eff4df
Status: NEW → RESOLVED
Closed: 9 years ago
Priority: P1 → P4
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.