642716 - nsHTMLCopyEncoder::IncludeInContext should check for |var| element rather than |variable|

Status: RESOLVED FIXED

(Core :: DOM: Serializers, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsHTMLCopyEncoder::IncludeInContext checks for the |variable| element where it presumably means to check for the |var| element.

Once we fix this, we can remove nsGkAtoms::variable, which otherwise could have been done in bug 642227.

This error dates back to:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/content/base/src&command=DIFF_FRAMESET&file=nsDocumentEncoder.cpp&rev2=1.42&rev1=1.41
1.42 <[e-mail]> 2001-02-15 05:22
bug 50497: plaintext copy loses newlines on paste
bug 57292: copy of table cell contents shouldn't copy cell
bug 57170: some inline style not preserved across copy paste
for all above: r=akkana; sr=sfraser

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 520135 [details] [diff] [review]
patch

r=me

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Actually, txXSLTAtoms is the same as nsGkAtoms, so I still can't remove the atom.  But that's fine.)

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/projects/birch/rev/0a25284172dc

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/mozilla-central/rev/0a25284172dc