Closed Bug 642716 Opened 9 years ago Closed 9 years ago

nsHTMLCopyEncoder::IncludeInContext should check for |var| element rather than |variable|

Categories

(Core :: DOM: Serializers, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(1 file)

nsHTMLCopyEncoder::IncludeInContext checks for the |variable| element where it presumably means to check for the |var| element.

Once we fix this, we can remove nsGkAtoms::variable, which otherwise could have been done in bug 642227.

This error dates back to:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/content/base/src&command=DIFF_FRAMESET&file=nsDocumentEncoder.cpp&rev2=1.42&rev1=1.41
1.42 <jfrancis@netscape.com> 2001-02-15 05:22
bug 50497: plaintext copy loses newlines on paste
bug 57292: copy of table cell contents shouldn't copy cell
bug 57170: some inline style not preserved across copy paste
for all above: r=akkana; sr=sfraser
Attachment #520135 - Flags: review?(bzbarsky)
Comment on attachment 520135 [details] [diff] [review]
patch

r=me
Attachment #520135 - Flags: review?(bzbarsky) → review+
Assignee: nobody → dbaron
(Actually, txXSLTAtoms is the same as nsGkAtoms, so I still can't remove the atom.  But that's fine.)
https://hg.mozilla.org/mozilla-central/rev/0a25284172dc
Status: NEW → RESOLVED
Closed: 9 years ago
Priority: -- → P3
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in before you can comment on or make changes to this bug.