642549 - Re-review Mac OS X address book integration code and check for leaks

Status: NEW

(Thunderbird :: Address Book, defect)

Description

[Josh Aas]

The code for Mac OS X address book integration in bug 203927 was committed to comm-central despite deserved r- reviews. Among other problems there is at least one obvious leak which made it into the tree and was pointed out by Stuart Morgan in that bug in 2007:

https://bugzilla.mozilla.org/show_bug.cgi?id=203927#c130

I recommend reading all of the existing review comments in that bug and doing a proper review of that code. Maybe back it out until that is done.

Comment 1

[rsx11m]

Actually, this was committed to CVS on 2007-08-04, well before comm-central,
and was in the first TB 3.0 alpha. If this is the first bug report filed on
the memory leak (thus after almost four years), backing the code out at this
late time would seem like overreacting at the cost of loosing that feature.

Comment 2

[Mark Banner (:standard8)]

We won't back it out, its been in the code base far too long for that. I suspect the fact it was r- just got missed at the time.

The best way forward seems to be just to do a re-review of the code. I can do that generally, although it would be helpful to have an additional person who understands the subtle details of the Mac style code to check for leaks.

Comment 3

[Wayne Mery (:wsmwk)]

ref bug 463594 comment 16

Comment 4

[Mark Banner (:standard8)]

I don't have time to work on this, but someone with mac experience is welcome to look through the code.