642604 - window.close() from a content tab closes Fennec window

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Extension Compatibility, defect)

Description

[Wladimir Palant]

This is the Fennec equivalent of bug 503299. It seems that webpages cannot call window.close(), it won't work even for pop-up windows. However, a chrome page loaded into the browser (typically an extension page) has the necessary privileges. Instead of closing a single tab it will close the entire Fennec window. Fennec should be intercepting DOMWindowClose event in the <browser> tag and closing a single tab.

Comment 1

[Matt Brubeck (:mbrubeck)]

Nominating for Fennec 4.next / Fennec 5.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Fennec does listen for the DOMWindowClose event, and sends a message to the parent process which tries to close a tab. Local (about:) pages should also send the message. Something must be getting messed up.

Comment 3

[Matt Brubeck (:mbrubeck)]

In addition to sending a message from the frame script, we probably need to catch the event in the parent process (when it bubbles from a local tab to its <browser>) and stopPropagation.

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

There's just a simple JavaScript error in our DOMWindowClosed handler, which means we aren't calling preventDefault when we want to.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 520268 [details] [diff] [review]
patch

oh how I wish we saw this 2 days ago

Comment 6

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/707a52a816f0

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110905
Firefox/8.0a1 Fennec/8.0a1
Device: Samsung Galaxy S
OS: Android 2.2