642902 - we leak invalid profiles in the jpeg decoder.

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

The original patch for color management added this leak.

The leak was found using the 'leaks' tool on OS X and recognizing icc profiles in the memory contents.

The leak is failing to free here:
http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/decoders/nsJPEGDecoder.cpp#257

Comment 1

[Joe Drew (not getting mail)]

Attachment: don't leak the profile

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Example image

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: try again

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: and again

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add crashtest that will expose the leak

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Add crashtest that will expose the leak v2

Address review comments

Comment 7

[Joe Drew (not getting mail)]

http://hg.mozilla.org/projects/cedar/rev/952373d0334e
http://hg.mozilla.org/projects/cedar/rev/0fdc05b3cd03

Comment 8

[(no longer active)]

Landing this on cedar turned out to cause some problems:

Talos crash:
http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1300910008.1300910194.30255.gz&fulltext=1

Reftest failure:
http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1300908691.1300909022.24616.gz&fulltext=1

Webgl crash:
http://tinderbox.mozilla.org/showlog.cgi?log=Cedar/1300909925.1300910308.30609.gz&fulltext=1#err0

Joe backed it out of cedar.

Comment 9

[Joe Drew (not getting mail)]

Attachment: don't crash if we have a profile

poor.

qcms_profile_from_memory() takes a void* as its first argument, so screwing this argument up didn't fail to compile.

Comment 10

[Joe Drew (not getting mail)]

Attachment: don't crash if we have a profile

actually qref

Comment 11

[Joe Drew (not getting mail)]

http://hg.mozilla.org/projects/cedar/rev/9bc4aefb44db
http://hg.mozilla.org/projects/cedar/rev/c1be34bded71
and, because I'm a moron:
http://hg.mozilla.org/projects/cedar/rev/5ad746647a66

Comment 12

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/9bc4aefb44db
http://hg.mozilla.org/mozilla-central/rev/c1be34bded71
and, because Joe is a pretty smart guy who makes a few mistakes rarely, just because he's human:
http://hg.mozilla.org/mozilla-central/rev/5ad746647a66