we leak invalid profiles in the jpeg decoder.

RESOLVED FIXED in mozilla5

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jrmuizel, Assigned: joe)

Tracking

({memory-leak})

unspecified
mozilla5
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 4 obsolete attachments)

Reporter

Description

8 years ago
The original patch for color management added this leak.

The leak was found using the 'leaks' tool on OS X and recognizing icc profiles in the memory contents.

The leak is failing to free here:
http://mxr.mozilla.org/mozilla-central/source/modules/libpr0n/decoders/nsJPEGDecoder.cpp#257

Updated

8 years ago
Keywords: mlk
Assignee

Updated

8 years ago
Assignee: nobody → joe
Component: GFX: Color Management → ImageLib
OS: Mac OS X → All
QA Contact: color-management → imagelib
Hardware: x86 → All
Assignee

Comment 1

8 years ago
Attachment #520252 - Flags: review?(jmuizelaar)
Reporter

Updated

8 years ago
Blocks: mlk-fx5+
Reporter

Updated

8 years ago
Attachment #520252 - Flags: review?(jmuizelaar) → review+
Reporter

Updated

8 years ago
Depends on: post2.0
Reporter

Comment 2

8 years ago
Posted image Example image (obsolete) —
Reporter

Comment 3

8 years ago
Posted image try again (obsolete) —
Attachment #520312 - Attachment is obsolete: true
Reporter

Comment 4

8 years ago
Posted image and again
Attachment #520313 - Attachment is obsolete: true
Reporter

Comment 5

8 years ago
Attachment #520319 - Flags: review?(joe)
Reporter

Comment 6

8 years ago
Address review comments
Attachment #520319 - Attachment is obsolete: true
Attachment #520319 - Flags: review?(joe)
Assignee

Updated

8 years ago
Attachment #520320 - Flags: review+
Assignee

Comment 9

8 years ago
poor.

qcms_profile_from_memory() takes a void* as its first argument, so screwing this argument up didn't fail to compile.
Attachment #521291 - Flags: review?(jmuizelaar)
Assignee

Updated

8 years ago
Whiteboard: not-ready
Assignee

Comment 10

8 years ago
actually qref
Attachment #521291 - Attachment is obsolete: true
Attachment #521291 - Flags: review?(jmuizelaar)
Attachment #521292 - Flags: review?(jmuizelaar)
Reporter

Updated

8 years ago
Attachment #521292 - Flags: review?(jmuizelaar) → review+

Comment 12

8 years ago
http://hg.mozilla.org/mozilla-central/rev/9bc4aefb44db
http://hg.mozilla.org/mozilla-central/rev/c1be34bded71
and, because Joe is a pretty smart guy who makes a few mistakes rarely, just because he's human:
http://hg.mozilla.org/mozilla-central/rev/5ad746647a66
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
No longer blocks: mlk-fx5+
You need to log in before you can comment on or make changes to this bug.