642927 - sharing from fbcdn.net to facebook errors

Status: RESOLVED INVALID

(Mozilla Labs :: F1, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

== copied from: https://github.com/mozilla/f1/issues#issue/84 ==

You cannot share stuff that is in fbcdn.net to facebook.  We need the server to capture this error and return it back to the client and the client should be displaying an error message for this type of share problem.

[Sun Mar 13 20:16:41 2011] [error] 20:16:41,242 INFO [linkdrop-metrics] [Dummy-1] domain='facebook.com' short_url=None when=1300072601.24227 remote_address='xxx' message_len=12 took=0.0 acct_id='xxx' long_url='http://video.l3.fbcdn.net/cfs-l3-snc6/81489/34/1605260179420_2624.mp4?oh=ac31b4d8738221641ba490396dc19636&oe=4D7F9F00&l3s=20110313100648&l3e=20110315101648&lh=0a6cfa5eeaecd6dc12abf' error={'status': 400, u'message': u'(#100) FBCDN image is not allowed in stream: http://video.l3.fbcdn.net/cfs-l3-snc6/81489/34/1605260179420_2624.mp4?oh=ac31b4d8738221641ba490396dc19636&oe=4D7F9F00&l3s=20110313100648&l3e=20110315101648&lh=0a6cfa5eeaecd6dc12abf', 'code': 0, u'type': u'OAuthException', 'provider': 'facebook.com'} id='send-error'

Comment 1

[Mark Hammond [:markh] [:mhammond]]

In the new addon you still get the error but it *is* surfaced to the user.  Sadly the full cryptic message above is surfaced (ie, including the (#100) prefix etc) but hopefully that will be addressed as part of bug 692003.

Seeing the initial comment in this bug seems to be that we didn't surface the error, can this one be closed?  Assigning to Shane as he initially reported the issue on github.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I've just struck this again, trying to share the facebook homepage itself to facebook.   The picture F1 chose as the image for the page is another facebook user (was actually Roland :)  The console shows:

Authorization: OAuth realm="graph.facebook.com"
link=http%3A%2F%2Fwww.facebook.com%2F&...&picture=http%3A%2F%2Fprofile.ak.fbcdn.net%2Fhprofile-ak-ash2%2F185999_867125135_252404_q.jpg&...
2011-11-25 12:23:17     oauthconsumer        DEBUG      call finished, calling callback
SEND FAILURE: error/(#100) FBCDN image is not allowed in stream: http://profile.ak.fbcdn.net/hprofile-ak-ash2/185999_867125135_252404_q.jpg
error: mediator reported invocation error: There was a problem sharing this page: (#100) FBCDN image is not allowed in stream: http://profile.ak.fbcdn.net/hprofile-ak-ash2/185999_867125135_252404_q.jpg

This is somewhat bad as there is nothing the user did to cause this error - it is F1 itself which picked the failing image.

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

f1 is no longer an active project.  delete these messages by searching for: [closing_f1_project_bugs]