643137 - strict alignment issues when displaying OpenType fonts on sparc64

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Landry Breuil (:gaston)]

Attachment: Fix alignment issues on strict archs

I've been reported this issue, which probably affects 1.9.1, 1.9.2 and 2.0 as the ots code is the same for all branches. Firefox crashes when displaying http://thebrowsereview.com/category/css3/ on sparc64.
The attached patch fixes the issue for the submitter, it should probably be pushed upstream (chromium ?)
It's a followup of https://bugzilla.mozilla.org/show_bug.cgi?id=527276 where OTS landed in all branches.

Comment 1

[Landry Breuil (:gaston)]

2.0 doesn't build/run on sparc64, but it'd be good if someone could land that in 1.9.1, 1.9.2 and 2.0 for the next point releases.

Comment 3

[Tobias Ulmer]

For reference, upstream bug report can be found here: https://code.google.com/p/chromium/issues/detail?id=76882

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/projects/cedar/rev/86d254c4f034

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/86d254c4f034

Comment 6

[Landry Breuil (:gaston)]

Do i need to open another bug asking for a backport to 1.9.1, 1.9.2 & 2.0 ?

Comment 7

[Landry Breuil (:gaston)]

Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Setting approval flag for 1.9.1/1.9.2/2.0 to ?
Please correct if it's not the right process...

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

The 1.9.1 branch didn't include OTS and we're not planning further releases off the 2.0 branch. If there are any they will be emergency security fixes for which this patch would be inappropriate.

Leaving the 1.9.2 request open

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Didn't make 3.6.18

Comment 10

[Landry Breuil (:gaston)]

And what's needed to get that commited ? approval-xxx is not enough now ?

Comment 11

[Dão Gottwald [:dao]]

The 2.0 branch is dead, removing checkin-needed.

Comment 12

[Landry Breuil (:gaston)]

Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Probably hopeless, but setting approval1.9.2.19 to ?

Comment 13

[LegNeato]

Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Approved for 1.9.2.19.

Comment 14

[Jonathan Kew [:jfkthame]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/364eff5eab14

Comment 15

[Al Billings [:abillings - ex-MoCo]]

Landry Breuil, can you verify this with the 1.9.2 candidates at ftp://ftp.mozilla.org/pub/firefox/nightly/3.6.20-candidates/. I have no Sparc64 machines with which to verify this fix.

Comment 16

[Landry Breuil (:gaston)]

Given that we(OpenBSD)'ve been shipping firefox 3.6.x with that patch since 3.6.16, i'd say it's been well enough tested. I have a limited time for that until 3.6.20 release..

Comment 17

[Landry Breuil (:gaston)]

3.6.20 Candidate build 1 works fine on sparc64 with that patch integrated, i can open http://thebrowsereview.com/category/css3/ without crashes. thanks!

Comment 18

[Al Billings [:abillings - ex-MoCo]]

Marking as verified for 1.9.2. Thanks!