Closed Bug 643137 Opened 9 years ago Closed 9 years ago

strict alignment issues when displaying OpenType fonts on sparc64

Categories

(Core :: Graphics, defect)

Other
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla5
Tracking Status
status1.9.2 --- .20-fixed

People

(Reporter: gaston, Assigned: gaston)

References

Details

(Keywords: verified1.9.2)

Attachments

(1 file)

I've been reported this issue, which probably affects 1.9.1, 1.9.2 and 2.0 as the ots code is the same for all branches. Firefox crashes when displaying http://thebrowsereview.com/category/css3/ on sparc64.
The attached patch fixes the issue for the submitter, it should probably be pushed upstream (chromium ?)
It's a followup of https://bugzilla.mozilla.org/show_bug.cgi?id=527276 where OTS landed in all branches.
Attachment #520448 - Flags: review?(roc)
Attachment #520448 - Attachment is patch: true
Attachment #520448 - Attachment mime type: application/octet-stream → text/plain
2.0 doesn't build/run on sparc64, but it'd be good if someone could land that in 1.9.1, 1.9.2 and 2.0 for the next point releases.
Keywords: checkin-needed
Assignee: nobody → landry
Duplicate of this bug: 644569
For reference, upstream bug report can be found here: https://code.google.com/p/chromium/issues/detail?id=76882
http://hg.mozilla.org/mozilla-central/rev/86d254c4f034
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2
Do i need to open another bug asking for a backport to 1.9.1, 1.9.2 & 2.0 ?
Blocks: 643460
Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Setting approval flag for 1.9.1/1.9.2/2.0 to ?
Please correct if it's not the right process...
Attachment #520448 - Flags: approval2.0?
Attachment #520448 - Flags: approval1.9.2.18?
Attachment #520448 - Flags: approval1.9.1.20?
Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

The 1.9.1 branch didn't include OTS and we're not planning further releases off the 2.0 branch. If there are any they will be emergency security fixes for which this patch would be inappropriate.

Leaving the 1.9.2 request open
Attachment #520448 - Flags: approval2.0?
Attachment #520448 - Flags: approval2.0-
Attachment #520448 - Flags: approval1.9.1.20?
Attachment #520448 - Flags: approval1.9.1.20-
Attachment #520448 - Flags: approval2.0-
Attachment #520448 - Flags: approval2.0+
Attachment #520448 - Flags: approval1.9.2.18?
Attachment #520448 - Flags: approval1.9.2.18+
Keywords: checkin-needed
Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Didn't make 3.6.18
Attachment #520448 - Flags: approval1.9.2.18+ → approval1.9.2.18-
And what's needed to get that commited ? approval-xxx is not enough now ?
The 2.0 branch is dead, removing checkin-needed.
Keywords: checkin-needed
Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Probably hopeless, but setting approval1.9.2.19 to ?
Attachment #520448 - Flags: approval1.9.2.19?
Comment on attachment 520448 [details] [diff] [review]
Fix alignment issues on strict archs

Approved for 1.9.2.19.
Attachment #520448 - Flags: approval1.9.2.19? → approval1.9.2.19+
Keywords: checkin-needed
Landry Breuil, can you verify this with the 1.9.2 candidates at ftp://ftp.mozilla.org/pub/firefox/nightly/3.6.20-candidates/. I have no Sparc64 machines with which to verify this fix.
Given that we(OpenBSD)'ve been shipping firefox 3.6.x with that patch since 3.6.16, i'd say it's been well enough tested. I have a limited time for that until 3.6.20 release..
3.6.20 Candidate build 1 works fine on sparc64 with that patch integrated, i can open http://thebrowsereview.com/category/css3/ without crashes. thanks!
Marking as verified for 1.9.2. Thanks!
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.