643191 - Add a "Copy link location" action to the context menu for links

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement, P3)

Description

[skierpage]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b11) Gecko/20110209 Firefox/4.0b11 SeaMonkey/2.1b2
Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110318 Firefox/4.0b13pre Fennec/4.0b6pre

On my HTC Evo (model PC36100) running HTC's Android 2.2,

The context menu for a link on a page doesn't have a way to copy its URL.  By comparison, the stock browser's context menu has a "Copy link URL" item, and Firefox desktop has "Copy Link Location"

Reproducible: Always

Steps to Reproduce:
1. Press and hold on a link in Fennec
Actual Results:  
Context menu appears with destination URL and the actions
  Open Link in New Tab
  Save Link
  Share Link


Expected Results:  
Provide a menu item to copy the link's URL.

One workaround is to open the link in new tab, tap location field to reveal the URL, press and hold location field, choose Copy from its context menu.

Also regarding the context menu for links, I filed bug 643186 that its first item should be Open.

Comment 2

[Anna (Waverley)]

Also"  <Fennec is missing the long-press actions "Copy Image URL", and "View Image" as present in other desktop and mobile browsers>

from bug 664798

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I really missed this while using Fennec to write comments on blogs/forums/bugzilla/etc.  The best workaround in Fennec is to open each link in a new tab, wait for each one to load, then copy it from the awesomescreen.  This is very time-consuming; sometimes it was faster to open the link in another screen instead.

With "Copy Link" in the context menu, use cases like these are much easier and quicker.  This also makes us more consistent with desktop Firefox and with other browsers (mobile and desktop).

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 546557 [details] [diff] [review]
patch

Yeah, I miss this too.

Comment 6

[CoJaBo]

Can the patch be expanded to add a "Copy Image URL" menu option? There is currently no means to do this other than opening the page in another browser.
"View Image" and "Copy Email Address" options would be nice as well, which should bring Firefox Mobile in line with most other desktop and mobile browsers.

Comment 7

[Matt Brubeck (:mbrubeck)]

Madhava also approved this change.

http://hg.mozilla.org/integration/mozilla-inbound/rev/28935aa0b26a

(In reply to comment #6)
> Can the patch be expanded to add a "Copy Image URL" menu option? There is
> currently no means to do this other than opening the page in another browser.
> "View Image" and "Copy Email Address" options would be nice as well, which
> should bring Firefox Mobile in line with most other desktop and mobile
> browsers.

I agree that at least some of these should be added, but let's file followup bug(s) for them.  We are trying to provide important features but also not let the menus get too long or cluttered, so I think the UX team should discuss whether and how to include these.

Comment 8

[CoJaBo]

Bug 664798 should be un-duped from this one if it is necessary to have separate bugs.

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/28935aa0b26a

Comment 10

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:8.0a1)Gecko/20110905
Firefox/8.0a1 Fennec/8.0a1
Device: Samsung Galaxy S
OS: Android 2.2

Comment 11

[donrhummy]

this is not fixed. it's missing in Firefox, Firefox beta and nightly

Comment 12

[Matt Brubeck (:mbrubeck)]

(In reply to donrhummy from comment #11)
> this is not fixed. it's missing in Firefox, Firefox beta and nightly

This wasn't included in the new Android UI rewrite.  I filed bug 769886 to re-add it.

Comment 13

[Cristian Nicolae (:xti)]

TC added in MozTrap: https://moztrap.mozilla.org/manage/cases/?filter-id=1335#caseversion-id-6412