Closed Bug 769886 Opened 10 years ago Closed 10 years ago
Add a "Copy link location" action to the context menu for links
+++ This bug was initially created as a clone of Bug #643191 +++ We added this to XUL Fennec, and we should add it to Fennec Native for the same reasons.
Assignee: mbrubeck → michael.l.comella
I noticed from bug 664798 that "Copy email address", "Copy phone number" and "Copy image location" (if not more) were desired in the previous XUL build and I believe they were lost on the switch to the Native UI. Are these still desired? Should I file separate bugs for them (or do they already exist)? Also, bug 718437 seems like a previously existing meta bug for this issue.
Changed (In reply to Michael Comella (:mcomella) from comment #3) > I noticed from bug 664798 that "Copy email address", "Copy phone number" and > "Copy image location" (if not more) were desired in the previous XUL build > and I believe they were lost on the switch to the Native UI. Are these still > desired? Should I file separate bugs for them (or do they already exist)? I changed bug 718437 into an official meta bug. Comments to this question should move to that bug's page.
I am unsure about a few things: 1) The name of the copy action in the context menu. "Copy Link" (which was in XUL) vs. "Copy Link Location" (which is specified in the bug). I chose the former since it was in production at one point. 2) The regex used in the Copyable context. I did not know which URI schemes we would want access to copy. I chose to omit "tel" and "mailto" as these would be covered by "Copy phone number" and "Copy email address" respectively (which are not currently implemented - see meta bug 718437). I am not sure if anything else should be omitted.
Attachment #643684 - Flags: review?(mark.finkle)
Attachment #643684 - Flags: review?(mark.finkle) → review+
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
Broken with Bug 766275. Will post patch shortly.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
For breaking it, you get to review it. :P You might want to double check Patch v2 for the other additions I reference, such as the string additions.
Attachment #644515 - Flags: review?(wjohnston)
Attachment #643917 - Attachment is obsolete: true
Comment on attachment 644515 [details] [diff] [review] Patch v3 Review of attachment 644515 [details] [diff] [review]: ----------------------------------------------------------------- Lol. Sorry again :(
Attachment #644515 - Flags: review?(wjohnston) → review+
No problem. I wish all my reviews were this fast! :)
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Build ID: 17.0a2 (2012-10-08)Aurora Channel 18.0b1 (2012-10-08) Nightly Channel 19.0b1 (2012-10-09) Nightly Channel Device: Samsung Galaxy Nexus OS: Android 4.1 Copy link location is now added to the context menu for regular links. Marking bug as verify fixed.
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.