1.08 KB, patch
|Details | Diff | Splinter Review|
From: http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserFocus [12/14/00] Proposed idl void activate(); void deactivate(); // Give the firstelementfocus within mozilla // (ie. TAB was pressedand focus should enter mozilla) void setFocusAtFirstElement(); // Give the last element focus within mozilla // (ie ALT-TAB was pressed andfocus should enter mozilla) void setFocusAtLastElement(); attribute nsIDOMWindowfocusedWindow; attribute nsIDOMElementfocusedElement; nsWebBrowser.cpp has some Activate() impl that could/should be leveraged here.
Updating QA Contact
Mozilla 0.8 builds started today. We would consider taking reviewed low risk fixes if they are available today (Wednesday, 7/Feb/01) or tomorrow (Thursday, 8/Feb/01). Otherwise, please retarget it for Mozilla 0.9.
Correction: Changing QA contact for the Embed API bugs to David Epstein.
Created attachment 31880 [details] [diff] [review] Implementation of nsWebBrowser::GetFocusedElement()
I attached an implementation of nsWebBrowser::GetFocusedElement. It is nearly identical to the existing code for GetFocusedWindow(). I may look into implementing the remaining bits of the nsIWebBrowserFocus if I have some time here.
patch looks right to me. r=saari
Yeah, looks great to me except for the fact that it isn't a diff with -u and is hard to read. :) sr=blizzard
Bug: Run mfcembed.exe, 0.9 mozilla, goto http://www.yahoo.com, after page loaded click to set focus on the URL field of the main window, then click on yahoo's text input field and type something, the output is expected to go into the search field, but it goes into the URL field. Cause: When use clicks on the content, nsIWebBrowserFocus::Activate() is not called if the main window never lose focus. Hence the content is not activated. Could the browser content activate itself when it receives mouse click and deactivate when mouse click outside of it?
It probably should. In the PPEmbed sample, it works just that way.
04/23/01 13:52 patch checked in: Checking in nsWebBrowser.cpp; /cvsroot/mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp,v <-- nsWebBrowser.cpp new revision: 1.81; previous revision: 1.80 done
Does this patch fix our focus problems?
Just talk to Alex, his patch has nothing to do with the problem specified, this is simply reproducible with mfcembed.exe. You can see two cursors (one in url field and one in the browser area) and text goes into the url field.
email@example.com, could you create a new bug bugzilla bug describing the problem that you have in mfcembed.exe (including the steps to reproduce it). I believe the existing problem in this bug is resolved.
No longer reproducible, I think it has been fixed.
Doesn't look like this is getting fixed before the freeze tonight. Pushing out a milestone. Please correct if I'm mistaken.
This was fixed a while ago.
checked code checkin in nsWebBrowser.cpp, in local mozilla build and lxr. Haven't seen focus problem in mfcEmbed.