implement nsIWebBrowserFocus

VERIFIED FIXED in mozilla0.9.4

Status

()

Core
Embedding: APIs
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: blizzard, Assigned: blizzard)

Tracking

({embed})

Trunk
mozilla0.9.4
x86
Linux
embed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needed by 05/08/01)

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
From:

http://www.mozilla.org/projects/embedding/apiReviewNotes.html#nsIWebBrowserFocus

[12/14/00]
Proposed idl
       void activate();
       void deactivate();

        // Give the firstelementfocus within mozilla
       // (ie. TAB was pressedand focus should enter mozilla)
       void setFocusAtFirstElement();

       // Give the last element focus within mozilla
              // (ie ALT-TAB was pressed andfocus should enter mozilla)
       void setFocusAtLastElement();
       attribute nsIDOMWindowfocusedWindow;
       attribute nsIDOMElementfocusedElement;

nsWebBrowser.cpp has some Activate() impl that could/should be leveraged here.

Comment 1

17 years ago
nominating 0.8
Keywords: embed, mozilla0.8

Comment 2

17 years ago
Updating QA Contact
QA Contact: jrgm → mdunn

Updated

17 years ago
Blocks: 64833

Comment 3

17 years ago
Mozilla 0.8 builds started today. We would consider taking reviewed low risk 
fixes if they are available today (Wednesday, 7/Feb/01) or tomorrow (Thursday, 
8/Feb/01). Otherwise, please retarget it for Mozilla 0.9.
(Assignee)

Updated

17 years ago
Target Milestone: --- → mozilla0.9

Updated

17 years ago
Blocks: 70229

Updated

17 years ago
Keywords: mozilla0.8.1

Updated

17 years ago
Keywords: mozilla0.8
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9 → mozilla0.9.1

Comment 4

17 years ago
Correction: Changing QA contact for the Embed API bugs to David Epstein.
QA Contact: mdunn → depstein

Comment 5

17 years ago
Created attachment 31880 [details] [diff] [review]
Implementation of nsWebBrowser::GetFocusedElement()

Comment 6

17 years ago
I attached an implementation of nsWebBrowser::GetFocusedElement.  It is nearly 
identical to the existing code for GetFocusedWindow().  I may look into 
implementing the remaining bits of the nsIWebBrowserFocus if I have some time 
here.  

Comment 7

17 years ago
patch looks right to me. r=saari
(Assignee)

Comment 8

17 years ago
Yeah, looks great to me except for the fact that it isn't a diff with -u and is
hard to read. :)

sr=blizzard

Updated

17 years ago
Blocks: 75664

Updated

17 years ago
Whiteboard: needed by 05/08/01

Comment 9

17 years ago
Bug: Run mfcembed.exe, 0.9 mozilla, goto http://www.yahoo.com, after page 
loaded click to set focus on the URL field of the main window, then click on 
yahoo's text input field and type something, the output is expected to go into 
the search field, but it goes into the URL field.

Cause: When use clicks on the content, nsIWebBrowserFocus::Activate() is not 
called if the main window never lose focus. Hence the content is not activated.

Could the browser content activate itself when it receives mouse click and 
deactivate when mouse click outside of it?
It probably should. In the PPEmbed sample, it works just that way.

Comment 11

17 years ago
04/23/01 13:52 patch checked in:

Checking in nsWebBrowser.cpp;
/cvsroot/mozilla/embedding/browser/webBrowser/nsWebBrowser.cpp,v  <-- 
nsWebBrowser.cpp
new revision: 1.81; previous revision: 1.80
done

Comment 12

17 years ago
Does this patch fix our focus problems?

Comment 13

17 years ago
Just talk to Alex, his patch has nothing to do with the problem specified, this 
is simply reproducible with mfcembed.exe. You can see two cursors (one in url 
field and one in the browser area) and text goes into the url field. 

Comment 14

17 years ago
edxu@hotmail.com, could you create a new bug bugzilla bug describing the problem 
that you have in mfcembed.exe (including the steps to reproduce it). I believe 
the existing problem in this bug is resolved.
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9.2
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.2 → mozilla0.9.3

Comment 15

17 years ago
No longer reproducible, I think it has been fixed.

Comment 16

17 years ago
Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone.  Please correct if I'm mistaken.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
(Assignee)

Comment 17

17 years ago
This was fixed a while ago.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 18

17 years ago
checked code checkin in nsWebBrowser.cpp, in local mozilla build and lxr.
Haven't seen focus problem in mfcEmbed.
Status: RESOLVED → VERIFIED

Updated

16 years ago
No longer blocks: 64833
You need to log in before you can comment on or make changes to this bug.