643576 - <input accept="{image,audio,video}/*"> does not work on MacOS X

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

See URL.

I'm guessing this is a bug in the Mac widget code, since this works on Linux and Windows.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

This appears to be Bug 377624 comment 19

Comment 2

[Mounir Lamouri (:mounir)]

I looked at that bug today between two glasses of champagne... I've been able to fix it locally. I will clean the patch a bit and attach the patch later this week.

FWIW, the reason of the bug is that MacOS X do not let the users to choose between different filters so the current implementations add all filters to the filtering list and if one of the filter is "*", it will not filter. And we actually add "*" and all images types when we try to filter with accept="image/*". BTW, this bug applies to audio/* and video/*.

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Rewrite nsFilePicker::GenerateFilterList

Comment 4

[Josh Aas]

Comment on attachment 521252 [details] [diff] [review]
Rewrite nsFilePicker::GenerateFilterList

>+  // On MacOS X, you can only use one filter type.
>+  if (mFilters.Length() <= (PRUint32)mSelectedTypeIndex) {
>+    return nil;
>+  }

This comment is confusing, just delete it.

I applied this patch and ran the resulting build. Now if I try to open a file by opening the browser and hitting cmd-o I can hardly select anything, not even HTML files. Seems like only text documents with no extension are selectable. Without this patch I can select just about anything. We can't have this behavioral regression, something else is wrong.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Inter diff

Actually, my patch had a minor issue... :)

Comment 6

[Mounir Lamouri (:mounir)]

Attachment: Rewrite nsFilePicker::GenerateFilterList

Comment 7

[Mounir Lamouri (:mounir)]

Follow up to change the filter: bug 646854.

Comment 8

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/373dd35f5f33