Closed Bug 643788 Opened 9 years ago Closed 9 years ago

Move cmd_exportToText, cmd_preview and cmd_editSendPage out of editorOverlay

Categories

(SeaMonkey :: Composer, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.2

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

Only Composer uses cmd_exportToText, cmd_preview and cmd_editSendPage so they should be moved out of editorOverlay into a more appropriate place.

This patch does that and moves their entities too - might need to apply patch from bug 643761 due to patch context.
Attachment #520947 - Flags: review?(neil)
Attachment #520947 - Flags: review?(neil)
Changes since v1.0:
* Fix bitrotting.
Attachment #520947 - Attachment is obsolete: true
Attachment #520957 - Flags: review?(neil)
Attachment #520957 - Flags: review?(neil) → review+
Unbitrotted
Attachment #520957 - Attachment is obsolete: true
Attachment #522820 - Flags: review+
Comment on attachment 522820 [details] [diff] [review]
Move cmd_exportToText, cmd_preview and cmd_editSendPage patch v1.0b

Requesting r for entity changes that affect TB
Attachment #522820 - Flags: review?(bugzilla)
Attachment #522820 - Flags: review?(bugzilla) → review?(bienvenu)
Attachment #522820 - Flags: review?(bienvenu) → review+
Changes since v1.0b:
* Respun fo fix issue introduced by the patch from bug 335375 where the toolbarbutton now shows the accesskey / label from the command element.

Requesting new review for those changes. No need for new TB review as no changes to files they use.
Attachment #522820 - Attachment is obsolete: true
Attachment #527091 - Flags: review?(neil)
Attachment #527091 - Flags: review?(neil) → review+
Comment on attachment 527091 [details] [diff] [review]
Move cmd_exportToText, cmd_preview and cmd_editSendPage patch v1.0c [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/aba7f1706d4c
Attachment #527091 - Attachment description: Move cmd_exportToText, cmd_preview and cmd_editSendPage patch v1.0c → Move cmd_exportToText, cmd_preview and cmd_editSendPage patch v1.0c [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.2a1
Depends on: 718276
You need to log in before you can comment on or make changes to this bug.