644097 - favicon is misplaced when resizing a stacked group

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P5)

Description

[Alex Lakatos[:AlexLakatos]]

Attachment: screenshot

The first website's favicon is sometimes misplaced (not in the upper left corner) when rapidly resizing (to minimum height and with)  a stacked group in Panorama.

Reproducible: Sometimes. You have to rapidly resize the group, with a diagonal movement.

Steps To Reproduce:
1.Enter Panorama Mode
2.Rapidly resize a stacked group

Actual Results:
2.The favicon is not in the upper left corner, but on the bottom margin, a little to the right

Expected Results:
2.The favicon is in the upper left corner

Comment 1

[Kevin Hanes]

I can confirm. I imagine it's a timing issue.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 3

[Raymond Lee [:raymondlee]]

Comment on attachment 524495 [details] [diff] [review]
patch v1

+    // determine the tabItem at the top of the stack
+    let tabItem, idx = 0;
+    while (!tabItem || !groupItem.isTopOfStack(tabItem))
+      tabItem = groupItem.getChild(idx++);

It's unlikely to happen but if this part fails, we would need up in a indefinite loop.

Otherwise, looks good.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 524495 [details] [diff] [review]
patch v1

Passed try:

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=1a650150be86

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

Comment 6

[Ian Gilman [:iangilman]]

Comment on attachment 524633 [details] [diff] [review]
patch v2

Looks good, assuming the test fails without the patch.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

(In reply to comment #6)
> Looks good, assuming the test fails without the patch.

Yeah it does. I (almost) always start with writing tests and make them pass :)

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 9

[Benjamin Stover (:stechz)]

Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/ee41fa88ae54

Comment 10

[George Carstoiu]

Verified with Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110410 Firefox/4.2a1pre