Closed Bug 644097 Opened 9 years ago Closed 9 years ago
favicon is misplaced when resizing a stacked group
The first website's favicon is sometimes misplaced (not in the upper left corner) when rapidly resizing (to minimum height and with) a stacked group in Panorama. Reproducible: Sometimes. You have to rapidly resize the group, with a diagonal movement. Steps To Reproduce: 1.Enter Panorama Mode 2.Rapidly resize a stacked group Actual Results: 2.The favicon is not in the upper left corner, but on the bottom margin, a little to the right Expected Results: 2.The favicon is in the upper left corner
I can confirm. I imagine it's a timing issue.
Priority: -- → P5
Target Milestone: --- → Future
Assignee: nobody → tim.taubert
Status: NEW → ASSIGNED
Comment on attachment 524495 [details] [diff] [review] patch v1 + // determine the tabItem at the top of the stack + let tabItem, idx = 0; + while (!tabItem || !groupItem.isTopOfStack(tabItem)) + tabItem = groupItem.getChild(idx++); It's unlikely to happen but if this part fails, we would need up in a indefinite loop. Otherwise, looks good.
Attachment #524495 - Flags: feedback?(raymond) → feedback+
Comment on attachment 524495 [details] [diff] [review] patch v1 Passed try: http://tbpl.mozilla.org/?tree=MozillaTryemail@example.com&rev=1a650150be86
Comment on attachment 524633 [details] [diff] [review] patch v2 Looks good, assuming the test fails without the patch.
Attachment #524633 - Flags: review?(ian) → review+
(In reply to comment #6) > Looks good, assuming the test fails without the patch. Yeah it does. I (almost) always start with writing tests and make them pass :)
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/ee41fa88ae54
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified with Mozilla/5.0 (Windows NT 5.1; rv:2.2a1pre) Gecko/20110410 Firefox/4.2a1pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.