64423 - nsEventStateManager::ChangeTextSize can set negative textsizes

Status: VERIFIED DUPLICATE of bug 54963

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

If you use the mousewheel to decrease the textsize it is possible to reduce the
size <= 0 causing strange behaviours.

Unfortuantly my mousewheel dosn't work in linux but the the patch is really
trivial:

---
 
   float textzoom;
   mv->GetTextZoom(&textzoom);
-  mv->SetTextZoom(textzoom + 0.1*change);
+  textzoom += 0.1*change;
+  if (textzoom > 0)
+    mv->SetTextZoom(textzoom);
 
   return NS_OK;
 }

---

I'll attach a complete cvs diff

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to nsEventStateManager.cpp

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

sorry, seems [e-mail] is responsibel for this piece of code. Could you
review

Comment 3

[Brian Ryner (not reading)]

I think this is really a specific case of bug 54963 (we should probably come up
with an upper bound as well).  However, this patch is definitely ok.  r=bryner.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

added patch that adds upper and lower bound that bug 54963 instead

*** This bug has been marked as a duplicate of 54963 ***

Comment 5

[Loco]

VERIFIED.

Comment 6

[Brian Ryner (not reading)]

transferring these to my netscape.com email.