Closed Bug 54963 Opened 24 years ago Closed 24 years ago

Mousewheel font sizing not bounded

Categories

(SeaMonkey :: UI Design, defect, P3)

Product:
SeaMonkey
Component:
UI Design
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: sicking)

References

Details

(Keywords: arch)

Attachments

(2 files)

patch that adds lower (0) and upper (5000%) bound
573 bytes, patch
Details | Diff | Splinter Review
Now textzoom is bounded 0-2000% . Also changes maximum for "Other..." menuitem
1.39 KB, patch
Details | Diff | Splinter Review 
ctrl wheel down until you reach the smallest size.
one more gets you to a default size (I think you're at 0)
one more gets you to the smallest size (I think you're at -1)
continuing to wheel down sizes up.
QA Contact: sairuh → janc
Actually, this happens for zoom 1%, 2% and 3%. So it's not necessarily a matter
of the mousewheel not being bounded, rather our font zoom backend being weird.

I'll file a bug on that, mark this depending on it. I suspect the mousewheel is
bounded, at least at the lower end. We really should add the 5000% bound at the
upper end (it completely kills the X server to try anything larger on lower end
machines).

Accepting bug for now.
Status: NEW → ASSIGNED
Marking this depending on bug 57971.
Depends on: 57971
Timeless: On which platforms did you test? What build?

pierre this was an arch issue, I was probably using windows (nt4 or w2k likely 
w/ mstsc), but assuming you could wheel elsewhere the problem should have 
occured there too. The bug was filed per jag.
Keywords: arch
And to answer the build question, knowing timeless, it was a late September,
early October trunk build.
cc'ing bryner... bryner, you probably put a lower bound (0) on this code, did
you put an upper bound in?
(I still have to find out where this code lives and have higher priority stuff
I'm working on, this one may be a lot easier to fix for you...)
The relevant section of code is in nsEventStateManager::ChangeTextSize
(layout/events/src/nsEventStateManager.cpp) -- simply add appropriate bounds
checking before calling SetTextZoom.

Please take a look at nasty little bug 61117 (and assign as appropriate.)
*** Bug 61117 has been marked as a duplicate of this bug. ***
*** Bug 49674 has been marked as a duplicate of this bug. ***
I've attatched a patch that adds an upper and lower bound in
nsEventStateManager::ChangeTextSize.

Please review
Keywords: patch, review
*** Bug 64423 has been marked as a duplicate of this bug. ***
I think the Text Size menu's `other' item has a lower upper bound than that.  
Can you make it the same?
Nevermind, you're right.
r=bryner

ben re-a='ed on irc.  r=blake for the second patch.  reassigning to jonas.
Assignee: disttsc → sicking
Status: ASSIGNED → NEW
Fix checked in.  Thanks for the patch.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Summary: ctrl+Mouse wheel [font sizing] not bounded. → Mousewheel font sizing not bounded
Bug 61117 (marked dup of this) was not at all fixed by this.

2001-010517 trunk linux: Complete freeze for over 5 minutes after a "heavy"
scroll" downsizing. (P3/500) During this the cursor completely vanished after
some minutes of heavy disk activity, and never returned, even after a killall
mozilla-bin. Had to kill X and restart to get it back. (RH6.2 XFree86-3.3.6-20)

In addition: The old default for mousewheel resizing is gone (shift+scroll)
(shouldn't that be the default when no special settings are done in prefs?)
hmm and.. when i click advanced/mousewheel in prefs, console says moo!
changing qacontact to jrgm
QA Contact: janc → jrgm
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: