Open Bug 644876 Opened 9 years ago Updated 7 years ago

Memory leak with Adblock Plus & Pagespeed enabled

Categories

(Firefox :: General, defect)

x86
Windows XP
defect
Not set

Tracking

()

UNCONFIRMED

People

(Reporter: nick, Unassigned)

References

()

Details

(Keywords: memory-leak, Whiteboard: [MemShrink:P3])

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0) Gecko/20100101 Firefox/4.0

Before visiting the test page webGL should be disabled in about:config, otherwise you will experience a more serious and probably unrelated memory leak (as described in bug 643651)

With webGL disabled, and adBlock plus enabled, I get a cumulative increase in memory when loading each new page of the site, leading to a crash after 5 pages and about 1.8GB of memory used.

Reproducible: Always

Steps to Reproduce:
1.Visit http://www.mapcrunch.com, with adblock plus enabled, and note the memory use in task manager.
2.Wait for images to load, then scroll to the bottom and go to the next page
3.Repeat step 2 and note any unrelenting increase in memory use in task manager.
Actual Results:  
Memory use increases by about 400MB per page, leading to an eventual crash once 2GB is used.
Blocks: mlk-fx5+
Keywords: mlk
Version: unspecified → Trunk
Is this on http://www.mapcrunch.com/gallery ?

Can't reproduce with adblock plus (v 1.3.5rc.2929) enabled with fanboy's list and fanboy's tracking list. 

Fanboy's filters in operation:

||pagead2.*/pagead/*.js|
||platform*.twitter.com^$third-party
||google-analytics.com^$third-party,domain=~google.com|~tube8.com|~priestville.org|~coedmagazine.com|~maxcdn.com|~bolha.com|~seekingalpha.com|~threatfire.com|~aftonbladet.se

And one custom filter (originally from Fanboy's Annoyances list):

||facebook.com/plugins/like.php?$third-party

What filters are you using on the page?

Are you using any other extensions such as no-script?
BTW, am using latests nightly build.
I cannot reproduce the bug with the latest nightly, only on 4.0.
Oh, that's interesting.  Maybe it's already been fixed?
I am not seeing this on WinXP SP2 FF4RC2/Minefield Fanboy/Easylist.
I can now reproduce the bug on the latest nightly. I jumped to a conclusion about Adblock a little too fast and missed something.

The memory leak only manifests itself when these 3 addons are enabled:

ABP 1.3.3
Firebug 1.7.0
Pagespeed 1.10.2

I mistakenly thought it was only Adblock because I was enabling them one by one to see which triggered the leak.

I installed the latest nightly, then, in about:config, set 

extensions.checkCompatibility.4.2a

...then installed the 3 addons. In FF4.0 there is no need to set this flag.

Thereafter, visiting subsequent pages on http://www.mapcrunch.com/gallery causes the cumulative memory increase.
Summary: Memory leak with Adblock Plus enabled → Memory leak with Adblock Plus, Firebug & Pagespeed enabled
Strangely, the bug remains even after disabling Firebug (in both 4.0 and latest nightly). So it's just

ABP 1.3.3
Pagespeed 1.10.2

which are enough to cause it. I say it's strange because Pagespeed claims to require Firebug.
Yes, I am unable to reproduce this with Adblock Plus 1.3.5 RC on Minefield (build 20110322 and 20110324). On each new page the memory use first increases significantly but then it always goes back to roughly 400 MB. I'll need to take a look at Pagespeed later, after Adblock Plus 1.3.5 is released.
Yes, Adblock alone doesn't produce the behaviour I described - my initial report was inaccurate. With a fresh profile and Adblock + Pagespeed, I can produce the bug every time.
No longer blocks: mlk-fx5+
Whiteboard: [MemShrink:P3]
Summary: Memory leak with Adblock Plus, Firebug & Pagespeed enabled → Memory leak with Adblock Plus & Pagespeed enabled
You need to log in before you can comment on or make changes to this bug.