quirky horizontal alignment for RTL?

RESOLVED FIXED in mozilla1.8beta3

Status

()

Core
Layout: Block and Inline
P2
normal
RESOLVED FIXED
17 years ago
9 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {rtl, testcase})

Trunk
mozilla1.8beta3
rtl, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [patch])

Attachments

(5 attachments, 2 obsolete attachments)

(Assignee)

Description

17 years ago
I just modified some of our quirky horizontal alignment code for LTR so that it
would work for RTL too, thinking it would fix bug 64490.  It didn't.  But we
might want to do this anyway.
(Assignee)

Comment 1

17 years ago
Created attachment 21933 [details] [diff] [review]
patch
(Assignee)

Comment 2

17 years ago
Hmmm... did these changes mess up
http://www.mozilla.org/projects/seamonkey/memory-and-performance/mandpa-tasklist.html
 ?
(Assignee)

Comment 3

17 years ago
I'll try to reassess whether we need this after bidi lands.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 4

17 years ago
Reality check.  Moving out to 0.9.1.
Target Milestone: mozilla0.9 → mozilla0.9.1
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.1 → mozilla0.9.2

Comment 5

17 years ago
Can you give me an idea of what a testcase would be and I will test it on my 
BIDI build?

Thanks
(Assignee)

Comment 6

17 years ago
(Within an RTL document:)

<div align="left">
  <table width="50%"><tr><td>This is a table.</td></tr></table>
</div>

It would be interesting to know what other browsers that support BIDI do here...

Comment 7

17 years ago
Internet Explorer 6 pretty much centers the text, whereas we right align it.

I think Internet Explorer gets it right in this case, so we probably have a bug 
here. I think the issue is does the div align="left" become a div align="right" 
in the RTL case.

To make it an RTL document, make it like this:

<html dir="rtl">
<div align="left">
  <table width="50%"><tr><td>This is a table.</td></tr></table>
</div>
</html>
(Assignee)

Comment 8

17 years ago
Is the table on the left edge or right edge of the page?  And where is the text
within the table?  (Sorry... should have been clearer that the split between
those 2 questions is what is important...)

Comment 9

17 years ago
Created attachment 32211 [details]
IE vs. Bidi Mozilla
(Assignee)

Comment 10

17 years ago
Created attachment 32217 [details]
more thorough testcase
(Assignee)

Comment 11

17 years ago
Created attachment 32219 [details]
how the above testcase looks in Mozilla with my patch
(Assignee)

Comment 12

17 years ago
So I think I have some bugs, but I should see if they exist without my patch...
(Assignee)

Updated

16 years ago
Target Milestone: mozilla0.9.2 → Future
(Assignee)

Comment 13

16 years ago
Created attachment 43930 [details] [diff] [review]
more up-to-date patch

Comment 14

16 years ago
Konqueror is completely broken with Mike Kaply's simple <div
align="left"><table>...</table></div>, so I guess we can only trust IE on this.
How come such an important patch is still waiting? Waiting for testers, or an R/SR?
(Assignee)

Comment 15

16 years ago
It's waiting because I don't know what, if anything, is really necessary (it
would be nice to see a screenshot of IE displaying the most recent testcase -- I
could probably produce one when I have access to a Windows box later) and
because the patch is, I think, somewhat broken.
(Assignee)

Updated

16 years ago
Priority: P3 → P4
Keywords: patch, testcase
Attachment #21933 - Attachment is obsolete: true

Updated

15 years ago
Blocks: 137995
Created attachment 97423 [details]
Screenshot of IE6
(Assignee)

Updated

15 years ago
Component: Layout → Layout: Block & Inline
(Assignee)

Updated

15 years ago
Blocks: 196292
(Assignee)

Updated

15 years ago
Whiteboard: [patch]

Comment 17

14 years ago
No activity for last 2 years, still present in Mozilla 1.5.

The problem is very simple: in left-aligned RTL context, tables are aligned to
the right, while everything else (text, images) is aligned to the left. 
As you can imagine, this arises in practice.

Trivial testcase: 

<html><body dir="rtl"><div align="left">
FOO
<table><tr><td>BAR</td></tr></table>
</div></body></html>

Mozilla right-justified "FOO" and left-justifies "BAR", while MSIE puts both on
the left. Konqueror does the same as Mozilla. The HTML and CSS specs, as far as
I can tell, leave this defined. Logic, consistency and installed base clearly
support the MSIE behavior.

Comment 18

14 years ago
*** Bug 154259 has been marked as a duplicate of this bug. ***
(Assignee)

Updated

14 years ago
Priority: P4 → P2
Target Milestone: Future → mozilla1.7alpha

Comment 19

12 years ago
Any progress on this bug?  As mozilla2eran@tromer.org mentioned, the test case
is very simple. Furthermore, if you modify that test case to:

<html><body dir="rtl"><div align="left">
FOO
<table align="left"><tr><td>BAR</td></tr></table>
</div></body></html>

You will see it fixes the problem. The bug seems to be as simple as a table not
inheriting the align attribute on a dir="rtl" page.  Whereas, on a dir="ltr"
page, tables *do* inherit an align="right" attribute.

Matt
(Assignee)

Updated

12 years ago
Target Milestone: mozilla1.7alpha → mozilla1.8beta3
(Assignee)

Comment 20

12 years ago
Comment 19 is quite misguided; what's inherited is very different from
align="left" on tables, which is floating, not block-alignment.

In any case, I'll post an updated patch shortly.  I'd note that my simple
request for a screenshot from somebody who used Windows took almost a year, so
please don't complain about it being slow.
(Assignee)

Comment 21

12 years ago
Created attachment 186270 [details] [diff] [review]
updated patch
Attachment #43930 - Attachment is obsolete: true
Attachment #186270 - Flags: superreview?(roc)
Attachment #186270 - Flags: review?(roc)
Attachment #186270 - Flags: superreview?(roc)
Attachment #186270 - Flags: superreview+
Attachment #186270 - Flags: review?(roc)
Attachment #186270 - Flags: review+
(Assignee)

Updated

12 years ago
Attachment #186270 - Flags: approval1.8b3?

Updated

12 years ago
Attachment #186270 - Flags: approval1.8b3? → approval1.8b3+
(Assignee)

Comment 22

12 years ago
Fix checked in to trunk, 2005-06-15 16:45 -0700.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.