645188 - Move preferences to services.share.*, create default prefs

Status: RESOLVED FIXED

(Cloud Services :: Share: Firefox Client, defect)

Comment 1

[Philipp von Weitershausen [:philikon]]

Attachment: v1

* Move extensions.ffshare.* to services.share.*
* Create default prefs for those
* Get rid of unused frontpage_url pref
* Pref naming convention: rename share_url to shareURL
* Use Services.prefs instead of FUEL (bug 644016)

Did not rename use_accel_key to something like enableF1Key since the same name is used in the web bits. I wonder, should we do the prefs in web UI as well? It seems to make more sense to avoid that round trip, no?

Comment 2

[James Burke]

(In reply to comment #1)
> Did not rename use_accel_key to something like enableF1Key since the same name
> is used in the web bits. I wonder, should we do the prefs in web UI as well? It
> seems to make more sense to avoid that round trip, no?

I can see that there could be other prefs that may want to be stored that only are used in the web content, but we still need to persist the values for them. The bitly prefs work like this, although I can see that particular one going away at some point. Having that pipeline used for use_accel_key also seems to fit in with that.

Maybe that would change after we get final Fx UI, but for now I would keep it as-is. We can rename the use_accel_key one to use more standard camelCase conventions, perhaps as part of the whole "versioned data API" change.

Comment 3

[Philipp von Weitershausen [:philikon]]

Attachment: v1.1

D'oh, forgot to update the patch with the latest changes in the working copy.

Comment 4

[Philipp von Weitershausen [:philikon]]

(In reply to comment #2)
> I can see that there could be other prefs that may want to be stored that only
> are used in the web content, but we still need to persist the values for them.

Sure. My point is more about the UI. I personally think the prefs for a built in Firefox feature should live in the Firefox preference dialog.

> Maybe that would change after we get final Fx UI, but for now I would keep it
> as-is.

I'm fine with that, but I think we should figure this out. Filed bug 645802.

> We can rename the use_accel_key one to use more standard camelCase
> conventions, perhaps as part of the whole "versioned data API" change.

Yup.

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/users/pweitershausen_mozilla.com/fx-share/rev/c59cca3a933c