645487 - Port Bug 539660 [Remove sessionstore.interval and sessionstore.resume_from_crash default values from nsSessionStore.js]

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Misak Khachatryan]

Attachment: patch

From parent bug:

Bug 535408 comment 4 doesn't make sense; we couldn't remove it from firefox.js,
as getIntPref would throw.

Defining JS getters shouldn't create any measurable overhead. Pretty much
anything not directly used in init() should be a lazy getter.

Defining _interval and _resume_from_crash as lazy getters but not _prefBranch
would make them depend on init() being called first, whereas currently they can
be accessed before init(). I suppose that shouldn't be a problem in practice,
but I'd like to avoid the not-immediately-obvious dependency anyway.

Comment 1

[[e-mail]]

Comment on attachment 522194 [details] [diff] [review]
patch

>+  XPCOMUtils.defineLazyGetter(this, "_prefBranch", function () {
>+    return Components.classes["@mozilla.org/preferences-service;1"]
>+                     .getService(Components.interfaces.nsIPrefService).getBranch("browser.")
>+                     .QueryInterface(Components.interfaces.nsIPrefBranch2);
Why doesn't this use Services.prefs.getBranch("browser.") ?
>-    this._prefBranch = Services.prefs.getBranch("browser.");
>-    this._prefBranch.QueryInterface(Components.interfaces.nsIPrefBranch2);

Comment 2

[Misak Khachatryan]

That i tried to fix first, replacing:

XPCOMUtils.defineLazyGetter(this, "_prefBranch", function () {
    return Services.prefs.getBranch("browser.")
                   .QueryInterface(Components.interfaces.nsIPrefBranch2);
}

and it somehow failed, so i go their way ...

Comment 3

[Misak Khachatryan]

Attachment: v2

It seems i made some type in my first try.

Comment 4

[Misak Khachatryan]

Attachment: correct patc

Sorry, this is the correct one.

Comment 5

[Misak Khachatryan]

Pushed: http://hg.mozilla.org/comm-central/rev/386b32158c14