646011 - two "Process Reviews" buttons appear when there are no Moderated Reviews

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Pratibha]

Steps:
-------
- Login at: https://addons.allizom.org/z/en-US/editors/queue/reviews
Compare this with https://addons.allizom.org/en-US/editors/queue/reviews

Observed result:
When there are zero "Moderated Reviews", it is noticed that:
-https://addons.allizom.org/z/en-US/editors/queue/reviews: displays two "Process Reviews" buttons
-https://addons.allizom.org/en-US/editors/queue/reviews : displays a message as "There are currently no reviews in moderation."

Comment 1

[Pratibha]

Attachment: screenshot compares the difference noticed

Comment 2

[Wil Clouser [:clouserw]]

The two buttons are just the header and footer, but we should have a message saying there are no reviews.

Comment 3

[Gregory Koberger (:gkoberger)]

https://github.com/jbalogh/zamboni/commit/e66ea4d6541dc716cd230098e1616d2e083a870c

Added a message and removed the duplicate button.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/z/en-US/editors/queue/reviews.