646021 - Remove JSON object parameters from TabBrowser methods

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All of our Mozmill tests which are using middleClick to open a link in a new tab has to be moved over to use the openInNewTab method of the TabBrowser class. Currently we have some test failures because middleClick doesn't check if the tab has been opened. openInNewTab waits for the event to occur.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ok, slightly transforming this bug. As it has turned out the JSON object parameters are too hard to use and we should remove them.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 [checked-in]

Comment 3

[u279076]

Comment on attachment 522657 [details] [diff] [review]
Patch v1 [checked-in]

Looks fine to me, r+.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport (1.9.2)

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport (1.9.1)

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 522657 [details] [diff] [review]
Patch v1 [checked-in]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/5680112e8fbd (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/d39ef8edd5b4 (2.0)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport v2 (1.9.2)

I forgot to pull before. Updated patch for head.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport v2.1 (1.9.2)

Now also qrefreshed. Sorry.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Backport v2 (1.9.1)

Same happened to my 1.9.1 branch.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Backports have been landed:
http://hg.mozilla.org/qa/mozmill-tests/rev/ec87f6d53408 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/34a0f4fdd9ad (1.9.1)