657368 - Test failure in endurance/testTabView/testSwitchTabs.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The endurance test in endurance/testTabView/testSwitchTabs.js is failing with the following stack:

ERROR | Test Failure: {"exception": {"message": "tabBrowser_openTab: Unknown event type - [object Object]", "lineNumber": 477, "stack": "tabBrowser_openTab([object Proxy])@resource://mozmill/stdlib/securable-module.js -> file:///Users/dave/workspace/mozmill-tests/default/lib/tabs.js:477\n@:0\n", "fileName": "resource://mozmill/stdlib/securable-module.js -> file:///Users/dave/workspace/mozmill-tests/default/lib/tabs.js"}}

According to Henrik this is a regression caused by bug 646021

Comment 1

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13443863

Comment 2

[u279076]

I'll try to get this fixed this week.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regressed by bug 646021. Sorry for that.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Fixes failing test. v1.0

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 536565 [details] [diff] [review]
Fixes failing test. v1.0

Looks good, but why do we have to use the button and don't simply remove the parameter completely?

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Fixes failing test. v1.1

(In reply to comment #5)
> Comment on attachment 536565 [details] [diff] [review] [review]
> Fixes failing test. v1.0
> 
> Looks good, but why do we have to use the button and don't simply remove the
> parameter completely?

Done.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/342d4118876e (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/fa3f15f4e9fa (mozilla-aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/284113fd94c7 (mozilla-beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/5964166d9e45 (mozilla-2.0)