646071 - Remove nsInt64 and nsUint64

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[(no longer active)]

I think nsInt64 and nsUint64 are not useful any more, since we already have code which fails to compile if the compiler doesn't support 64-bit arithmetic.  So I think we should just kill these two types, and replace them with PRInt64 and PRUint64.

Benjamin, do you agree?

Comment 1

[Benjamin Smedberg]

Yes, I thought I r+ed a patch a long time ago to remove them. Not sure where, though.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: part 1: reimplement nsTime using PRInt64

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Attachment: Part 2: replace nsInt64 with a typedef to PRInt64

Fix all the associated compiler problems.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

I started on part 3 which removes all the uses of nsInt64, I didn't get that far yet.

Comment 5

[(no longer active)]

Attachment: Part 3: Remove nsInt64.h, and convert all uses of nsInt64 and nsUint64 in the tree to PRInt64 and PRUint64, respectively

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 522923 [details] [diff] [review]
Part 3: Remove nsInt64.h, and convert all uses of nsInt64 and nsUint64 in the tree to PRInt64 and PRUint64, respectively

Personally, I'd suggest dropping the explicit conversions of literals and let them happen implicitly.

Comment 7

[(no longer active)]

(In reply to comment #6)
> Personally, I'd suggest dropping the explicit conversions of literals and let
> them happen implicitly.

I don't care much either way, but it's a lot of work, so I'll let Benjamin weigh in before doing the work.  :-)

Comment 8

[Benjamin Smedberg]

Comment on attachment 522758 [details] [diff] [review]
Part 2: replace nsInt64 with a typedef to PRInt64

We're removing the typedef in the next patch, right?

Comment 9

[(no longer active)]

http://hg.mozilla.org/projects/cedar/rev/1a9cfc4f46ef
http://hg.mozilla.org/projects/cedar/rev/15fbc1435e1a
http://hg.mozilla.org/projects/cedar/rev/61acff8dfb61

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/72fd2dac7505
http://hg.mozilla.org/mozilla-central/rev/ff09586ff85a
http://hg.mozilla.org/mozilla-central/rev/b7bfd0871b3f

Comment 11

[[e-mail]]

Was this announced anywhere?

Comment 12

[Jeff Muizelaar [:jrmuizel]]

(In reply to comment #11)
> Was this announced anywhere?

The removal was not, the deprecation was. Would an announcement have been valuable?

Comment 13

[(no longer active)]

(In reply to comment #11)
> Was this announced anywhere?

My apologies, we should have let the comm-central folks know beforehand.  I guess I owe you guys an editor fix of some sort now... :)