Remove nsInt64 and nsUint64

RESOLVED FIXED in mozilla5

Status

()

Core
XPCOM
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Ehsan, Assigned: jrmuizel)

Tracking

Trunk
mozilla5
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

7 years ago
I think nsInt64 and nsUint64 are not useful any more, since we already have code which fails to compile if the compiler doesn't support 64-bit arithmetic.  So I think we should just kill these two types, and replace them with PRInt64 and PRUint64.

Benjamin, do you agree?

Comment 1

7 years ago
Yes, I thought I r+ed a patch a long time ago to remove them. Not sure where, though.
(Reporter)

Updated

7 years ago
Assignee: ehsan → jmuizelaar
(Assignee)

Comment 2

7 years ago
Created attachment 522754 [details] [diff] [review]
part 1: reimplement nsTime using PRInt64
(Assignee)

Comment 3

7 years ago
Created attachment 522758 [details] [diff] [review]
Part 2: replace nsInt64 with a typedef to PRInt64

Fix all the associated compiler problems.
(Assignee)

Comment 4

7 years ago
I started on part 3 which removes all the uses of nsInt64, I didn't get that far yet.
(Reporter)

Updated

7 years ago
Attachment #522754 - Flags: review?(benjamin)
(Reporter)

Updated

7 years ago
Attachment #522758 - Flags: review?(benjamin)
(Reporter)

Comment 5

7 years ago
Created attachment 522923 [details] [diff] [review]
Part 3: Remove nsInt64.h, and convert all uses of nsInt64 and nsUint64 in the tree to PRInt64 and PRUint64, respectively
Attachment #522923 - Flags: review?(benjamin)
(Assignee)

Comment 6

7 years ago
Comment on attachment 522923 [details] [diff] [review]
Part 3: Remove nsInt64.h, and convert all uses of nsInt64 and nsUint64 in the tree to PRInt64 and PRUint64, respectively

Personally, I'd suggest dropping the explicit conversions of literals and let them happen implicitly.
(Reporter)

Comment 7

7 years ago
(In reply to comment #6)
> Personally, I'd suggest dropping the explicit conversions of literals and let
> them happen implicitly.

I don't care much either way, but it's a lot of work, so I'll let Benjamin weigh in before doing the work.  :-)

Updated

7 years ago
Attachment #522754 - Flags: review?(benjamin) → review+

Comment 8

7 years ago
Comment on attachment 522758 [details] [diff] [review]
Part 2: replace nsInt64 with a typedef to PRInt64

We're removing the typedef in the next patch, right?
Attachment #522758 - Flags: review?(benjamin) → review+

Updated

7 years ago
Attachment #522923 - Flags: review?(benjamin) → review+
(Reporter)

Comment 10

7 years ago
http://hg.mozilla.org/mozilla-central/rev/72fd2dac7505
http://hg.mozilla.org/mozilla-central/rev/ff09586ff85a
http://hg.mozilla.org/mozilla-central/rev/b7bfd0871b3f
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla2.2

Updated

7 years ago
Blocks: 647481
Was this announced anywhere?
(Assignee)

Comment 12

7 years ago
(In reply to comment #11)
> Was this announced anywhere?

The removal was not, the deprecation was. Would an announcement have been valuable?
(Reporter)

Comment 13

7 years ago
(In reply to comment #11)
> Was this announced anywhere?

My apologies, we should have let the comm-central folks know beforehand.  I guess I owe you guys an editor fix of some sort now... :)
Depends on: 654372
You need to log in before you can comment on or make changes to this bug.