nsWebBrowserPersist init list out of order - "warning: 'nsWebBrowserPersist::mWrapColumn' will be initialized after ... 'PRInt64 nsWebBrowserPersist::mTotalCurrentProgress' ... when initialized here (nsWebBrowserPersist.cpp:234)"

RESOLVED FIXED in mozilla6

Status

()

Core
Embedding: APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning], URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
nsWebBrowserPersist's init list is out of order since this cset:
  http://hg.mozilla.org/mozilla-central/rev/b7bfd0871b3f

The build warning is:
nsWebBrowserPersist.h: In constructor 'nsWebBrowserPersist::nsWebBrowserPersist()':
nsWebBrowserPersist.h:244:31: warning: 'nsWebBrowserPersist::mWrapColumn' will be initialized after
nsWebBrowserPersist.h:242:31: warning:   'PRInt64 nsWebBrowserPersist::mTotalCurrentProgress'
nsWebBrowserPersist.cpp:234:1: warning:   when initialized here
(Assignee)

Updated

6 years ago
(Assignee)

Comment 1

6 years ago
Created attachment 529641 [details] [diff] [review]
fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #529641 - Flags: review?(ehsan)
Comment on attachment 529641 [details] [diff] [review]
fix

Sorry!  In my defense, I *tried* to preserve the correct initialization order!  ;-)
Attachment #529641 - Flags: review?(ehsan) → review+
(Assignee)

Comment 3

6 years ago
No problem. :)

Adding checkin-needed keyword, in the hopes that this can ride along with something.  (Patch already has author & commit message set correctly, so it can be hg [q]imported)
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/759cb9d29ef3
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.