Closed
Bug 646257
Opened 13 years ago
Closed 13 years ago
Access key for expander button only works once
Categories
(SeaMonkey :: Bookmarks & History, defect)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.1b3
People
(Reporter: neil, Assigned: neil)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
When viewing the properties for a bookmark or livemark, an expander button appears to allow you to view a minimal or complete set or properties. This button has an access key, but the key only works once.
|
Assignee | |
Comment 1•13 years ago
|
||
The label expects the access key to be set on the controlled element, so when the toggle code in bookmarksManager.js sets the access key, there are now two access keys, one on the label, one on the button. If the two keys are different, then both keys work to uncollapse the pane! However if the two keys are the same, or if the pane is collapsed again, then the accelerator code detects a conflict and refuses to activate the button. The solution is to set the original access key on the button, where the label can overwrite it.
Attachment #522845 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pushed changeset 9ab5ebcff8fa to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Target Milestone: --- → seamonkey2.1b3
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•