Closed Bug 646257 Opened 12 years ago Closed 12 years ago

Access key for expander button only works once

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1b3

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

When viewing the properties for a bookmark or livemark, an expander button appears to allow you to view a minimal or complete set or properties. This button has an access key, but the key only works once.
Attached patch Proposed patchSplinter Review
The label expects the access key to be set on the controlled element, so when the toggle code in bookmarksManager.js sets the access key, there are now two access keys, one on the label, one on the button. If the two keys are different, then both keys work to uncollapse the pane! However if the two keys are the same, or if the pane is collapsed again, then the accelerator code detects a conflict and refuses to activate the button. The solution is to set the original access key on the button, where the label can overwrite it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #522845 - Flags: review?(iann_bugzilla)
Attachment #522845 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 9ab5ebcff8fa to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 647877
Target Milestone: --- → seamonkey2.1b3
Version: unspecified → Trunk
No longer depends on: 647877
You need to log in before you can comment on or make changes to this bug.