Last Comment Bug 646257 - Access key for expander button only works once
: Access key for expander button only works once
Product: SeaMonkey
Classification: Client Software
Component: Bookmarks & History (show other bugs)
: Trunk
: All All
-- minor (vote)
: seamonkey2.1b3
Assigned To:
Depends on:
Blocks: 580662
  Show dependency treegraph
Reported: 2011-03-29 16:16 PDT by
Modified: 2011-04-06 02:21 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Proposed patch (1.25 KB, patch)
2011-03-29 16:21 PDT,
iann_bugzilla: review+
Details | Diff | Splinter Review

Description User image 2011-03-29 16:16:45 PDT
When viewing the properties for a bookmark or livemark, an expander button appears to allow you to view a minimal or complete set or properties. This button has an access key, but the key only works once.
Comment 1 User image 2011-03-29 16:21:00 PDT
Created attachment 522845 [details] [diff] [review]
Proposed patch

The label expects the access key to be set on the controlled element, so when the toggle code in bookmarksManager.js sets the access key, there are now two access keys, one on the label, one on the button. If the two keys are different, then both keys work to uncollapse the pane! However if the two keys are the same, or if the pane is collapsed again, then the accelerator code detects a conflict and refuses to activate the button. The solution is to set the original access key on the button, where the label can overwrite it.
Comment 2 User image 2011-04-02 14:39:03 PDT
Pushed changeset 9ab5ebcff8fa to comm-central.

Note You need to log in before you can comment on or make changes to this bug.