Closed Bug 646419 Opened 13 years ago Closed 13 years ago

Update add-ons manager main controls for Firefox nav bar styling changes

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla5

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file, 1 obsolete file)

patch
1.52 KB, patch
Unfocused
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
Bug 603790 reduced the textbox and button radii and removed the textbox shadows in Firefox's navigation toolbar on Windows. The attached patch ports this to the add-ons manager.
Attachment #522970 - Flags: review?(bmcbride)
Severity: enhancement → trivial
Blocks: 638526
No longer blocks: 638526
Comment on attachment 522970 [details] [diff] [review]
patch

New style looks good.

Looks like you forgot to remove the box-shadow from the search box though.

Also, while testing, I found some regressions from bug 623199 (see bug 646713), which are somewhat related.
Attachment #522970 - Flags: review?(bmcbride) → review-
Attached patch patch — — Splinter Review 
yeah, missed the shadow
Attachment #522970 - Attachment is obsolete: true
Attachment #523251 - Flags: review?(bmcbride)
Attachment #523251 - Flags: review?(bmcbride) → review+
http://hg.mozilla.org/mozilla-central/rev/f76c34fd7228
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
wtf? no glow on the buttons?
(In reply to comment #4)
> cc: rakshithbekal@yahoo.inwtf? no glow on the buttons?

Yes, if they are active. The settings gear button will "glow" on mouse hover and if you have accessed the details of an installed add-on, the back arrow will do likewise.

I assume that is what you are asking about.
You assumed Right
Looks fine except for the search field in classic mode. I have filed bug 654019 to handle that regression.

Verified fixed with Mozilla/5.0 (Windows NT 6.1; rv:5.0a2) Gecko/20110501
Firefox/5.0a2
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: