646574 - dis() is broken when function has upvars

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

Regression from rev cc4fdccc1135 (bug 396512).

Works:
dis("-r", function f(v) { return function() { return 5; } })

Doesn't work, returns a mess of question marks:
dis("-r", function k(v) { return function() { return v; } })

Comment 1

[Jesse Ruderman]

Can trigger the bug without "-r", by using an escaping closure:
dis((function k(v) { return function() { return v; } })(4))

Looks like the "flags" and "upvars" sections got eaten.

Comment 2

[Jeff Walden [:Waldo]]

2186	                if (script->bindings.hasUpvars()) {
2187	                    Sprint(sp, "\nupvars: {\n");
2188	
2189	                    void *mark = JS_ARENA_MARK(&cx->tempPool);
2190	                    jsuword *localNames = script->bindings.getLocalNameArray(cx, &cx->tempPool);
2191	                    if (!localNames)
2192	                        return false;

I suspect this nested arena-mark here is the problem.

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is really being a PITA for debugging things....

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Patch

Try not to gag too much.

Comment 5

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/b79cf02287c6

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/b79cf02287c6

Comment 7

[Christian Holler (:decoder)]

Filter on qa-project-auto-change:

Bug in removed tracer code, setting in-testsuite- flag.