Closed Bug 647423 Opened 11 years ago Closed 6 years ago

Remove __defineGetter__ and __defineSetter__ support

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Future

People

(Reporter: bruant.d, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

In Jeff Walden's blog post (http://whereswalden.com/2010/04/16/more-spidermonkey-changes-ancient-esoteric-very-rarely-used-syntax-for-creating-getters-and-setters-is-being-removed/) is written the intention to remove __defineGetter__ and __defineSetter__ support in the longer run.

Unlike in bug 642500 (remove mutable __proto__), all use cases for __defineGetter__ and __defineSetter__ are covered by a standradized alternative; namely Object.defineProperty.
OS: Linux → All
Hardware: x86 → All
Target Milestone: --- → Future
Version: unspecified → Trunk
Depends on: 791944
Assignee: general → nobody
Depends on: 1219366
I think this should be wontfixed. The only thing that happened since Waldo's blog post is that IE was, despite their claims cited in the blog post, forced to implemented them in IE11.

We don't have an infinite budget for breaking changes, so out of all the things that would actually simplify the engine, I don't think that the benefit of removing 70 lines of self-hosted JS are worth the cost.
jorendorff, as module owner, can you please make the call?
Flags: needinfo?(jorendorff)
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(jorendorff)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.