791944 - Use Object.defineProperty() instead of __defineGetter__ in XPCOMUtils.defineLazyGetter()

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Use Object.defineProperty() instead of __defineGetter__ in XPCOMUtils.defineLazyGetter()

Comment 1

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 662055 [details] [diff] [review]
patch

Given that I know little about this file, I looked at the hg log, checked out the last bug to make a significant change and looked at the reviewer for that patch. Benjamin, you're up!

Comment 3

[Benjamin Smedberg]

Comment on attachment 662055 [details] [diff] [review]
patch

I'm going to delegate this to mak since .defineProperty isn't something I've worked with before, and he wrote a lot of this file.

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 662055 [details] [diff] [review]
patch

Review of attachment 662055 [details] [diff] [review]:
-----------------------------------------------------------------

Yes this works the same, __defineGetter__ is deprecated, so good to replace it.

Did you see bug 647423? Maybe you could be interested in filing dependencies of it and start doing a platform wide replacement.
Likely would also be a good first bug, fwiw.

::: js/xpconnect/loader/XPCOMUtils.jsm
@@ +176,5 @@
> +        delete aObject[aName];
> +        return aObject[aName] = aLambda.apply(aObject);
> +      },
> +      configurable: true,
> +      enumerable: true,

please remove the trailing comma from here

Comment 5

[Marco Bonardo [:mak]]

already tested by current tests using defineLazy*Anything*

Comment 6

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Attachment: patch rev1.1

(In reply to Marco Bonardo [:mak] from comment #4)
> Did you see bug 647423? Maybe you could be interested in filing dependencies
> of it and start doing a platform wide replacement.
> Likely would also be a good first bug, fwiw.

Thank you, Marco. I'll look into it.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c89fff328c4c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c89fff328c4c