Closed Bug 647820 Opened 9 years ago Closed 9 years ago
Don't use -mno-cygwin on mingw compilation
This option has been deprecated for a while and now is completely removed in GCC 4.6 (causing compilation errors on an attempt to use it). What we really want is -mwindows.
Comment on attachment 524062 [details] [diff] [review] fix v1.0 (NSS part) I'm not an NSS peer, I can't review this.
Attachment #524062 - Flags: review?(ted.mielczarek) → review?(bsmith)
Attachment #524063 - Flags: review?(ted.mielczarek) → review+
Attachment #524060 - Flags: review?(ted.mielczarek) → review+
Thanks for reviews! I've pushed m-c part: http://hg.mozilla.org/projects/build-system/rev/dd0f92e2ea92 I'm setting checkin-needed for nspr part, because AFAIU it requires special privileges.
Whiteboard: [checkin: comment 5]
Status: NEW → ASSIGNED
ted, can you land this in NSPR's CVS repo? Or do we have someone else with that access?
I can, yes.
This patch is waiting to be pushed since a month. Would be nice to have it landed before it bitrot.
Well, it's in NSPR, so it's unlikely to bitrot. Only a handful of people have access to that though ... somebody should bug ted on IRC on Monday.
Sorry, after I added comment 8, I found out that NSPR trunk was frozen for a release. I can land this on Monday.
Checking in configure; /cvsroot/mozilla/nsprpub/configure,v <-- configure new revision: 1.303; previous revision: 1.302 done Checking in configure.in; /cvsroot/mozilla/nsprpub/configure.in,v <-- configure.in new revision: 1.305; previous revision: 1.304 done Well, it's *a* monday.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [checkin to NSPR needed]
Comment on attachment 524063 [details] [diff] [review] fix v1.0 (nspr part) r=wtc. This patch is in NSPR_4_8_9_BETA2.
Attachment #524063 - Flags: review+
pushed nspr patch as part of http://hg.mozilla.org/mozilla-central/rev/b20b6d500c05
Thanks for reviews and committing! I've filled bug 662362 as follow-up for NSS part.
You need to log in before you can comment on or make changes to this bug.