647820 - Don't use -mno-cygwin on mingw compilation

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jacek Caban]

This option has been deprecated for a while and now is completely removed in GCC 4.6 (causing compilation errors on an attempt to use it). What we really want is -mwindows.

Comment 1

[Jacek Caban]

Attachment: fix v1.0 (m-c part)

Comment 2

[Jacek Caban]

Attachment: fix v1.0 (NSS part)

Comment 3

[Jacek Caban]

Attachment: fix v1.0 (nspr part)

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 524062 [details] [diff] [review]
fix v1.0 (NSS part)

I'm not an NSS peer, I can't review this.

Comment 5

[Jacek Caban]

Thanks for reviews!

I've pushed m-c part:
http://hg.mozilla.org/projects/build-system/rev/dd0f92e2ea92

I'm setting checkin-needed for nspr part, because AFAIU it requires special privileges.

Comment 6

[Mitchell Field [:Mitch]]

http://hg.mozilla.org/mozilla-central/rev/dd0f92e2ea92

Comment 7

[Boris Zbarsky [:bzbarsky]]

ted, can you land this in NSPR's CVS repo?  Or do we have someone else with that access?

Comment 8

[(not currently active) Ted Mielczarek]

I can, yes.

Comment 9

[Mounir Lamouri (:mounir)]

This patch is waiting to be pushed since a month. Would be nice to have it landed before it bitrot.

Comment 10

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Well, it's in NSPR, so it's unlikely to bitrot.  Only a handful of people have access to that though ... somebody should bug ted on IRC on Monday.

Comment 11

[(not currently active) Ted Mielczarek]

Sorry, after I added comment 8, I found out that NSPR trunk was frozen for a release. I can land this on Monday.

Comment 12

[(not currently active) Ted Mielczarek]

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.303; previous revision: 1.302
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.305; previous revision: 1.304
done

Well, it's *a* monday.

Comment 13

[Wan-Teh Chang]

Comment on attachment 524063 [details] [diff] [review]
fix v1.0 (nspr part)

r=wtc.  This patch is in NSPR_4_8_9_BETA2.

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

pushed nspr patch as part of http://hg.mozilla.org/mozilla-central/rev/b20b6d500c05

Comment 15

[Jacek Caban]

Thanks for reviews and committing! I've filled bug 662362 as follow-up for NSS part.