Don't use -mno-cygwin on mingw compilation

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
This option has been deprecated for a while and now is completely removed in GCC 4.6 (causing compilation errors on an attempt to use it). What we really want is -mwindows.
(Assignee)

Comment 1

7 years ago
Created attachment 524060 [details] [diff] [review]
fix v1.0 (m-c part)
Attachment #524060 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 2

7 years ago
Created attachment 524062 [details] [diff] [review]
fix v1.0 (NSS part)
Attachment #524062 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

7 years ago
Created attachment 524063 [details] [diff] [review]
fix v1.0 (nspr part)
Attachment #524063 - Flags: review?(ted.mielczarek)
Comment on attachment 524062 [details] [diff] [review]
fix v1.0 (NSS part)

I'm not an NSS peer, I can't review this.
Attachment #524062 - Flags: review?(ted.mielczarek) → review?(bsmith)
Attachment #524063 - Flags: review?(ted.mielczarek) → review+
Attachment #524060 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

6 years ago
Thanks for reviews!

I've pushed m-c part:
http://hg.mozilla.org/projects/build-system/rev/dd0f92e2ea92

I'm setting checkin-needed for nspr part, because AFAIU it requires special privileges.
Keywords: checkin-needed
Whiteboard: [checkin: comment 5]
Whiteboard: [checkin: comment 5] → [checkin to NSPR needed]
http://hg.mozilla.org/mozilla-central/rev/dd0f92e2ea92
Status: NEW → ASSIGNED
ted, can you land this in NSPR's CVS repo?  Or do we have someone else with that access?
I can, yes.
This patch is waiting to be pushed since a month. Would be nice to have it landed before it bitrot.
Well, it's in NSPR, so it's unlikely to bitrot.  Only a handful of people have access to that though ... somebody should bug ted on IRC on Monday.
Sorry, after I added comment 8, I found out that NSPR trunk was frozen for a release. I can land this on Monday.
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.303; previous revision: 1.302
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.305; previous revision: 1.304
done

Well, it's *a* monday.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [checkin to NSPR needed]

Comment 13

6 years ago
Comment on attachment 524063 [details] [diff] [review]
fix v1.0 (nspr part)

r=wtc.  This patch is in NSPR_4_8_9_BETA2.
Attachment #524063 - Flags: review+
pushed nspr patch as part of http://hg.mozilla.org/mozilla-central/rev/b20b6d500c05
(Assignee)

Updated

6 years ago
Depends on: 662362
(Assignee)

Updated

6 years ago
Attachment #524062 - Attachment is obsolete: true
Attachment #524062 - Flags: review?(bsmith)
(Assignee)

Comment 15

6 years ago
Thanks for reviews and committing! I've filled bug 662362 as follow-up for NSS part.
You need to log in before you can comment on or make changes to this bug.