Closed Bug 647820 Opened 9 years ago Closed 9 years ago

Don't use -mno-cygwin on mingw compilation

Categories

(Firefox Build System :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(2 files, 1 obsolete file)

This option has been deprecated for a while and now is completely removed in GCC 4.6 (causing compilation errors on an attempt to use it). What we really want is -mwindows.
Attachment #524060 - Flags: review?(ted.mielczarek)
Attached patch fix v1.0 (NSS part) (obsolete) — Splinter Review
Attachment #524062 - Flags: review?(ted.mielczarek)
Attachment #524063 - Flags: review?(ted.mielczarek)
Comment on attachment 524062 [details] [diff] [review]
fix v1.0 (NSS part)

I'm not an NSS peer, I can't review this.
Attachment #524062 - Flags: review?(ted.mielczarek) → review?(bsmith)
Attachment #524063 - Flags: review?(ted.mielczarek) → review+
Attachment #524060 - Flags: review?(ted.mielczarek) → review+
Thanks for reviews!

I've pushed m-c part:
http://hg.mozilla.org/projects/build-system/rev/dd0f92e2ea92

I'm setting checkin-needed for nspr part, because AFAIU it requires special privileges.
Keywords: checkin-needed
Whiteboard: [checkin: comment 5]
Whiteboard: [checkin: comment 5] → [checkin to NSPR needed]
ted, can you land this in NSPR's CVS repo?  Or do we have someone else with that access?
This patch is waiting to be pushed since a month. Would be nice to have it landed before it bitrot.
Well, it's in NSPR, so it's unlikely to bitrot.  Only a handful of people have access to that though ... somebody should bug ted on IRC on Monday.
Sorry, after I added comment 8, I found out that NSPR trunk was frozen for a release. I can land this on Monday.
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.303; previous revision: 1.302
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.305; previous revision: 1.304
done

Well, it's *a* monday.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Whiteboard: [checkin to NSPR needed]
Comment on attachment 524063 [details] [diff] [review]
fix v1.0 (nspr part)

r=wtc.  This patch is in NSPR_4_8_9_BETA2.
Attachment #524063 - Flags: review+
Depends on: 662362
Attachment #524062 - Attachment is obsolete: true
Attachment #524062 - Flags: review?(bsmith)
Thanks for reviews and committing! I've filled bug 662362 as follow-up for NSS part.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.