647875 - [SeaMonkey] mochitest-chrome: investigate test_crash_submit.xul failure, then reenable this test

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect, P2)

Description

[Serge Gautherie (:sgautherie)]

Bug 604129 comment 2:
{
Serge Gautherie (:sgautherie)      2010-10-29 01:17:03 PDT

I assume this depends on bug 601493.
}

That bug is fixed. It's time to check how this test behaves (now).

***

[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110330 Firefox/4.0pre] (O-1301536603)
[Mozilla/5.0 (Windows NT 5.0; rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre SeaMonkey/2.1b3pre]
[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110331 Firefox/4.0pre SeaMonkey/2.1b3pre]
[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110403 Firefox/4.0pre SeaMonkey/2.1b3pre]
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul | Exited with code -1073741819 during test run
}

Ftr, this test (now) crashes the test suite on my Windows 2000 :-/

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove bug 604129 workaround [Checked in: Comments 13 and 16]

Callek, I'm looking for someone to confirm whether SeaMonkey passes this test currently.

Comment 2

[Josh Aas]

Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

If it passes I'm fine with this.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

I won't be able to test locally for at least 2 weeks; I think we can just go ahead and get this landed, and move on. I think it should work fine now.

Comment 4

[Ian Neal]

Now get on SM Nightly:
1144 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60

Comment 5

[Justin Wood (:Callek)]

(In reply to comment #4)
> Now get on SM Nightly:
> 1144 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul |
> [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null
> at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60

Given this, I'll prefer we don't re-enable yet. I'll plan to test in the next week or so.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> Ftr, this test (now) crashes the test suite on my Windows 2000 :-/

I recorded some "ftr" details in bug 604129 comment 14.


(In reply to comment #4)
> [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null
> at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60

That (was =) is bug 604129.
Hum, so its cause isn't fixed yet :-/ "helpwanted" to figure that out.


(In reply to comment #5)
> I'll prefer we don't re-enable yet. I'll plan to test in the next week or so.

Yeah, that's why I wanted a confirmation before pushing. Thanks.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Ftr, this test (now) crashes the test suite on my Windows 2000 :-/

[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

It looks like 'pluginElement.crash();' isn't catched as expected.
Forget about that as W2K isn't supported on SM 2.10+.

Comment 8

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey [Fixed by bug 752548]

On a recent SM 2.12a1 on local Windows Vista, the test doesn't crash but it "cycles" :-/

I have no idea what is going on exactly (broken build? SM issue? broken Core code? ...),
but here is a workaround that lets the load event (etc) fully complete before clicking.

Ftr, expected steps are:
1. The plugin loads and is crashed from runTests().
2. A "click to submit" link is displayed and is clicked from onPluginCrashed().
3. A "click to reload the page" link is displayed...

Comment 9

[[e-mail]]

Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

>+  // SeaMonkey needs executeSoon(), not to cycle on executing onPluginCrashed().
>+  SimpleTest.executeSoon(function delayedClick() {
>+    sendMouseEvent({type:'click'}, pleaseLink, window);
>+  });
> }
> 
> function runTests() {
>   if (navigator.userAgent.match(/ SeaMonkey\//)) {
Should you alter this too, or is more work needed?

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to [e-mail] from comment #9)
> >   if (navigator.userAgent.match(/ SeaMonkey\//)) {
> Should you alter this too, or is more work needed?

Patch A should be enough.

Comment 11

[[e-mail]]

Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

Sorry, I didn't realise that it was a dependant patch.

What's happening here is that Firefox switched from bubbling to capturing event listeners for its plugin events because of bug 335586.

Although that bug patched other events that SeaMonkey was already using, when we then went on the implement the plugin events we forgot to capture them :-(

When we start capturing the events we'll see them before content does, so that the event will have been handled by the time the test sees the event.

Comment 12

[Serge Gautherie (:sgautherie)]

Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

(In reply to [e-mail] from comment #11)
> What's happening here is that Firefox switched from bubbling to capturing
> event listeners for its plugin events because of bug 335586.

Thanks!
I filed bug 752548.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

https://hg.mozilla.org/mozilla-central/rev/f2755b6925e4


[Approval Request Comment]
No risk, (SeaMonkey) test-only.

Comment 14

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1336467536.1336474654.26403.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/05/08 01:58:56
{
4263 INFO TEST-END | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_submit.xul | finished in 2226ms
}

V.Fixed

Comment 15

[Alex Keybl [:akeybl]]

Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

[Triage Comment]
Test-only, approved for Aurora 14 and Beta 13.

Comment 16

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

http://hg.mozilla.org/releases/mozilla-aurora/rev/2bfec66e13f4
http://hg.mozilla.org/releases/mozilla-beta/rev/172b2b9f140f