Closed Bug 647875 Opened 9 years ago Closed 8 years ago

[SeaMonkey] mochitest-chrome: investigate test_crash_submit.xul failure, then reenable this test

Categories

(Toolkit :: Crash Reporting, defect, P2, major)

defect

Tracking

()

VERIFIED FIXED
mozilla15
Tracking Status
firefox12 --- wontfix
firefox13 --- wontfix
firefox14 --- wontfix
firefox-esr10 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(1 file, 1 obsolete file)

Bug 604129 comment 2:
{
Serge Gautherie (:sgautherie)      2010-10-29 01:17:03 PDT

I assume this depends on bug 601493.
}

That bug is fixed. It's time to check how this test behaves (now).

***

[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110330 Firefox/4.0pre] (O-1301536603)
[Mozilla/5.0 (Windows NT 5.0; rv:2.0b13pre) Gecko/20110301 Firefox/4.0b13pre SeaMonkey/2.1b3pre]
[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110331 Firefox/4.0pre SeaMonkey/2.1b3pre]
[Mozilla/5.0 (Windows NT 5.0; rv:2.0pre) Gecko/20110403 Firefox/4.0pre SeaMonkey/2.1b3pre]
{
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul | Exited with code -1073741819 during test run
}

Ftr, this test (now) crashes the test suite on my Windows 2000 :-/
Callek, I'm looking for someone to confirm whether SeaMonkey passes this test currently.
Attachment #524080 - Flags: review?(joshmoz)
Attachment #524080 - Flags: feedback?(bugspam.Callek)
Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

If it passes I'm fine with this.
Attachment #524080 - Flags: review?(joshmoz) → review+
Keywords: qawanted
Whiteboard: [qaw: comment 1]
Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

I won't be able to test locally for at least 2 weeks; I think we can just go ahead and get this landed, and move on. I think it should work fine now.
Attachment #524080 - Flags: feedback?(bugspam.Callek) → feedback+
Depends on: 640464
Now get on SM Nightly:
1144 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60
(In reply to comment #4)
> Now get on SM Nightly:
> 1144 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/chrome/modules/plugin/test/test_crash_submit.xul |
> [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null
> at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60

Given this, I'll prefer we don't re-enable yet. I'll plan to test in the next week or so.
(In reply to comment #0)
> Ftr, this test (now) crashes the test suite on my Windows 2000 :-/

I recorded some "ftr" details in bug 604129 comment 14.


(In reply to comment #4)
> [SimpleTest/SimpleTest.js, window.onerror] An error occurred - aTarget is null
> at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:60

That (was =) is bug 604129.
Hum, so its cause isn't fixed yet :-/ "helpwanted" to figure that out.


(In reply to comment #5)
> I'll prefer we don't re-enable yet. I'll plan to test in the next week or so.

Yeah, that's why I wanted a confirmation before pushing. Thanks.
Assignee: sgautherie.bz → nobody
Status: ASSIGNED → NEW
Keywords: qawantedhelpwanted
Summary: [SeaMonkey] mochitest-chrome: reenable test_crash_submit.xul → [SeaMonkey] mochitest-chrome: investigate test_crash_submit.xul failure, then reenable this test
Whiteboard: [qaw: comment 1]
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Ftr, this test (now) crashes the test suite on my Windows 2000 :-/

[Mozilla/5.0 (Windows NT 5.0; rv:13.0a1) Gecko/20120201 Firefox/13.0a1 SeaMonkey/2.10a1] (nightly, 2012-02-01-00-30-09-comm-central-trunk)

It looks like 'pluginElement.crash();' isn't catched as expected.
Forget about that as W2K isn't supported on SM 2.10+.
On a recent SM 2.12a1 on local Windows Vista, the test doesn't crash but it "cycles" :-/

I have no idea what is going on exactly (broken build? SM issue? broken Core code? ...),
but here is a workaround that lets the load event (etc) fully complete before clicking.

Ftr, expected steps are:
1. The plugin loads and is crashed from runTests().
2. A "click to submit" link is displayed and is clicked from onPluginCrashed().
3. A "click to reload the page" link is displayed...
Attachment #621576 - Flags: review?(ted.mielczarek)
Attachment #621576 - Flags: feedback?(neil)
Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

>+  // SeaMonkey needs executeSoon(), not to cycle on executing onPluginCrashed().
>+  SimpleTest.executeSoon(function delayedClick() {
>+    sendMouseEvent({type:'click'}, pleaseLink, window);
>+  });
> }
> 
> function runTests() {
>   if (navigator.userAgent.match(/ SeaMonkey\//)) {
Should you alter this too, or is more work needed?
(In reply to neil@parkwaycc.co.uk from comment #9)
> >   if (navigator.userAgent.match(/ SeaMonkey\//)) {
> Should you alter this too, or is more work needed?

Patch A should be enough.
Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

Sorry, I didn't realise that it was a dependant patch.

What's happening here is that Firefox switched from bubbling to capturing event listeners for its plugin events because of bug 335586.

Although that bug patched other events that SeaMonkey was already using, when we then went on the implement the plugin events we forgot to capture them :-(

When we start capturing the events we'll see them before content does, so that the event will have been handled by the time the test sees the event.
Attachment #621576 - Flags: feedback?(neil) → feedback-
Depends on: 752548
Comment on attachment 621576 [details] [diff] [review]
(Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey
[Fixed by bug 752548]

(In reply to neil@parkwaycc.co.uk from comment #11)
> What's happening here is that Firefox switched from bubbling to capturing
> event listeners for its plugin events because of bug 335586.

Thanks!
I filed bug 752548.
Attachment #621576 - Attachment description: (Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey → (Bv1) test_crash_submit.xul: Add an 'executeSoon()' to support SeaMonkey [Fixed by bug 752548]
Attachment #621576 - Attachment is obsolete: true
Attachment #621576 - Flags: review?(ted.mielczarek)
Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

https://hg.mozilla.org/mozilla-central/rev/f2755b6925e4


[Approval Request Comment]
No risk, (SeaMonkey) test-only.
Attachment #524080 - Attachment description: (Av1) Remove bug 604129 workaround → (Av1) Remove bug 604129 workaround [Checked in: Comment 13]
Attachment #524080 - Flags: approval-mozilla-beta?
Attachment #524080 - Flags: approval-mozilla-aurora?
Assignee: nobody → sgautherie.bz
Severity: normal → major
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Keywords: helpwanted
Priority: -- → P2
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1336467536.1336474654.26403.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/05/08 01:58:56
{
4263 INFO TEST-END | chrome://mochitests/content/chrome/dom/plugins/test/test_crash_submit.xul | finished in 2226ms
}

V.Fixed
Status: RESOLVED → VERIFIED
Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

[Triage Comment]
Test-only, approved for Aurora 14 and Beta 13.
Attachment #524080 - Flags: approval-mozilla-beta?
Attachment #524080 - Flags: approval-mozilla-beta+
Attachment #524080 - Flags: approval-mozilla-aurora?
Attachment #524080 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
Whiteboard: [c-n: f2755b6925e4 to m-a and m-b]
Comment on attachment 524080 [details] [diff] [review]
(Av1) Remove bug 604129 workaround
[Checked in: Comments 13 and 16]

http://hg.mozilla.org/releases/mozilla-aurora/rev/2bfec66e13f4
http://hg.mozilla.org/releases/mozilla-beta/rev/172b2b9f140f
Attachment #524080 - Attachment description: (Av1) Remove bug 604129 workaround [Checked in: Comment 13] → (Av1) Remove bug 604129 workaround [Checked in: Comments 13 and 16]
Keywords: checkin-needed
Whiteboard: [c-n: f2755b6925e4 to m-a and m-b]
You need to log in before you can comment on or make changes to this bug.