Closed Bug 648372 Opened 14 years ago Closed 14 years ago

fix direct message use

Categories

(Cloud Services :: Server: Share, defect)

Product:
Cloud Services
Component:
Server: Share
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mixedpuppy, Assigned: markh)

References

Details

Attachments

(4 files)

hotfix patch for current server
4.71 KB, patch
Details | Diff | Splinter Review
patch applied to linkoauth library in server-share-core
4.46 KB, patch
Details | Diff | Splinter Review
Pointer to Github pull request: https://github.com/mozilla/f1/pull/123
334 bytes, text/html
mixedpuppy
: review+
Details
Pointer to Github pull request: https://github.com/mozilla/server-share-core/pull/2
373 bytes, text/html
mixedpuppy
: review+
Details
reenable direct messaging that was disabled for Bug 647509 1. get a patch together for the current live server 2. create a patch plus tests for the new server code
Assignee: nobody → mixedpuppy
Patch is the same changes as in the hotfix, but applied to linkoauth.
Attachment #524673 - Flags: review?(tarek)
The patch looks good to me, but I think we want to add a specific test here that exercise the new behavior.
assigning to mark for getting the test code to support tests for this.
Assignee: mixedpuppy → mhammond
Depends on: 648601
both linkdrop and server-share-core have branches named bug/648372. The linkdrop branch has good coverage for facebook, but not yet for twitter and linkedin as the test framework doesn't yet support those services - so adding bugs for that to the deps list.
Depends on: 649248, 643877
As per discussion with Shane, we will not let linkedin mocking/testing holdup the landing of this.
No longer depends on: 649248
Attachment #526186 - Flags: review?(mixedpuppy)
Attachment #526185 - Flags: review?(mixedpuppy)
Attachment #526185 - Flags: review?(mixedpuppy) → review+
Attachment #526186 - Flags: review?(mixedpuppy) → review+
Attachment #524671 - Flags: review?(tarek)
Attachment #524671 - Flags: feedback?(dascher)
Attachment #524673 - Flags: review?(tarek)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: