648549 - Reviews with multiple OS files always show all files pending full review

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0) Gecko/20100101 Firefox/4.0
Build Identifier: 

If an addon version has multiple xpis/jars uploaded to support multiple OSs and one has already been approved/rejected the review page still shows all files as pending review.
This can lead to a waste of time attempting to review for an OS thats already been approved.


Reproducible: Always

Steps to Reproduce:
1. Go to a review page for an addon with 2 or more supported Operating Systems
2. approve 1 file, leaving the others
3. go back to the review page
Actual Results:  
both files still show as pending review

Expected Results:  
the file you approved earlier now shows 'fully reviewed' or 'preliminary reviewed', the other(s) show pending review.

the review history log shows correctly, and the admin control panel confirms approval.

Worked in Remora, doesn't in Zamboni.

Comment 1

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/d9e9eb5

This fixes the problem, however due to the conflicting comment linked below, it might break something else.  I did my best to make sure it didn't, but QA, watch out for that.

https://bugzilla.mozilla.org/show_bug.cgi?id=642941#c11

Comment 2

[Gregory Koberger (:gkoberger)]

Here's what it should look like now: http://grab.by/9Srp

Comment 3

[krupa raj[:krupa]]

verified fixed @ https://addons.allizom.org/en-US/editors/review/763840?num=1

Comment 4

[krupa raj[:krupa]]

Attachment: post-fix screenshot

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...