Closed
Bug 648596
Opened 14 years ago
Closed 14 years ago
False positive: "Missing comments in <script> tag"
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)
Tracking
(Not tracked)
RESOLVED
FIXED
Q2 2011
People
(Reporter: jorgev, Assigned: basta)
References
()
Details
(Whiteboard: [ReviewTeam])
Attachments
(1 file)
|
183.31 KB,
application/x-xpinstall
|
Details |
These validation results are flagging an parsing error incorrectly as "Missing comments in <script> tag". It looks like the real problem here is that the file has a number of localized strings that is breaking the parser or something.
|
Assignee | |
Comment 1•14 years ago
|
||
Can I get an example XPI?
|
Reporter | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
The problem was due to unicode problems. I updated the markup parser for the new unicode changes that I'm working on and things seem to be working just fine:
https://github.com/mattbasta/amo-validator/commit/908287ce7671d3840bbb64a031472383a914e591
This will be pushed as soon as one of the issues with Spidermonkey gets ironed out. I'm going to deal with that today.
|
|
Assignee | |
Updated•14 years ago
|
|
||
Updated•14 years ago
|
Target Milestone: 6.0.7 → Q2 2011
|
|
Assignee | |
Comment 4•14 years ago
|
||
Fixed and merged into mozilla/amo-validator:
https://github.com/mozilla/amo-validator/commit/6e2e1fd6b4b98a968b66acae7529cebcc9fe19c6
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 5•13 years ago
|
||
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•