648603 - Bump up max HTTP proxy connection limits

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Jason Duell]

We currently set network.http.max-persistent-connections-per-proxy to 8:

http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#712

Chrome sets the analogous number to 32:

   http://tinyurl.com/3es2a9x

When we're not using persistent proxy connections, it looks like we use the same limit for proxies as we do for hosts (network.http.max-connections-per-server), set to 15:

  http://mxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js#702

We may want to split out a separate pref for that and use a higher number for proxies?  (or just have a single max-proxy-connections setting for both persistent/non-persistent, as Chrome seems to be using).

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

I've updated the desktop proxy limit to 32.

I've updated b2g connection limits to match the fennec ones we updated a couple months ago.. specifically up to 6 per host and 20 overall.

I've also updated the mobile and b2g proxy limit to 20, which matches their total connection limit.

Comment 4

[Jason Duell]

Comment on attachment 657569 [details] [diff] [review]
patch 0

Review of attachment 657569 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +44,5 @@
>  pref("network.http.proxy.pipelining", true);
>  pref("network.http.pipelining.maxrequests" , 6);
>  pref("network.http.keep-alive.timeout", 600);
> +pref("network.http.max-connections", 20);
> +pref("network.http.max-persistent-connections-per-server", 6);

These are nice to have for B2G, assuming they work well.  I'm +r-ing on the assumption that we'll have a plan to evaluate that they do indeed improve perf.

::: mobile/xul/app/mobile.js
@@ +88,5 @@
>  pref("network.http.pipelining.maxrequests" , 6);
>  pref("network.http.keep-alive.timeout", 600);
>  pref("network.http.max-connections", 6);
>  pref("network.http.max-persistent-connections-per-server", 4);
> +pref("network.http.max-persistent-connections-per-proxy", 6);

might as well be 20, like rest of mobile/b2g?   That said mobile-xul is probably going away soon, so not really an issue.

Comment 5

[Jason Duell]

cjones/dietrich/dougt:  so this patch will also raise HTTP max-simultaneous connnections from 6 to 20, which should be a win provided the larger # of sockets/etc doesn't cause some sort of issue.  Any chance we could get someone with an Otero device to sanity-check that bumping up these prefs (can set in about:config: network.http.max-connections and network.http.max-persistent-connections-per-proxy) does indeed help?

Comment 6

[Patrick McManus [:mcmanus]]

thanks jason - these changes recently benefited android.. the old inherited mobile values are about 4 years out of date now, so b2g should minimally ride that curve imo.

Comment 7

[Patrick McManus [:mcmanus]]

I gave mobile-xul {20,6,20} for consistency with android in case anyone wants to run it.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2bc7b6958cd

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2bc7b6958cd

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to httpd.js to increase maxConnections

I'm going to land this pending review, to fix the problems described in the commit message within the patch.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4c8694da32f7

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4c8694da32f7