All users were logged out of Bugzilla on October 13th, 2018

Performance results with negative impact on some platforms should not be suppressed

RESOLVED WONTFIX

Status

P4
normal
RESOLVED WONTFIX
8 years ago
3 years ago

People

(Reporter: gaubugzilla, Unassigned)

Tracking

unspecified
4.x (triaged)

Details

(Reporter)

Description

8 years ago
I think that the following change to AMO's code will primarily hide issues with the measurements: https://github.com/jbalogh/zamboni/commit/80cc09c5db23cfc2cfc5b52ffcd125b640454fb1. A result where the measurement goes into negative is extremely unlikely if the measurement was performed correctly, currently such results are primarily caused by bug 648229. Also, if a fluctuation causes the baseline test to return a higher value this code will cause many add-ons to simply disappear from the map. If you don't want to accept negative numbers then use max(delta, 0), don't throw the result away.
To me it makes more sense not to show a failed test than show an incorrect result. An incorrect result would be more misleading IMO.

My suggestion is WONTFIX.
Component: Public Pages → Developer Pages
Priority: -- → P2
QA Contact: web-ui → developers
Target Milestone: --- → 6.0.5

Updated

8 years ago
Blocks: 648784
(Reporter)

Comment 2

8 years ago
All the more reason not to suppress "strange" results. If you are certain that tests with negative results are always incorrect then it is a reason to rerun the test. At the very least the add-on should be marked with "performance test failed". If you simply suppress these results you will get into a situation again where issues like bug 648229 go unnoticed.
Testing errors should definitely be logged, and I don't have any problems on them being public somehow. However, I disagree that the patch should be backed out, which is what this bug is about.
(Reporter)

Comment 4

8 years ago
What I asked for is a different handling of suspicious results - in its current form it is perfect for hiding bugs. And it did so at least once already.
Target Milestone: 6.0.5 → Q2 2011

Comment 5

8 years ago
Could we have AMO annotate the display with a "some tests failed" comment or something like that?
Priority: P2 → P4
Target Milestone: Q2 2011 → 4.x (triaged)
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

3 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.