Closed Bug 648844 Opened 13 years ago Closed 13 years ago

localized text in extension download tooltip doesn't fit

Categories

(SeaMonkey :: UI Design, defect)

x86_64
Windows 7
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1final

People

(Reporter: zart, Assigned: neil)

References

Details

Attachments

(3 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3

When installing add-on there is a tooltip with progress bar and action button, with explanation text below. On localized version text doesn't fit and gets shortened even though the whole window is supposed to be auto-sized so it shall fit completely.

Reproducible: Always

Steps to Reproduce:
1. try to install some addon while using non-english locale
2. extension tooltip appears with progress info, which gets shortened instead of fitting

Actual Results:  
Label content is shortened with "text..."

Expected Results:  
Tooltip window should get wider to make whole content of the label fit inside (screen width permitting).

Happens to me on russian locale. Other locales that have translations longer than original are probably affected too.
Ah, I thought that it would have stretched the doorhanger to fit the label.

Could you attach a screenshot of the equivalent Firefox doorhanger to compare?
Attached image Same window in FF4
Firefox resizes window properly.
Attached patch Possible patch (obsolete) — Splinter Review
After looking more closely, it actually happens in en-US too, but my internet connection is fast enough that it flashes by and I hadn't noticed before.

The problem is that the description is normally limited to 248px to make it wrap. Firefox works around this by fixing the width at 350px, which does avoid the problem of the popup resizing as it progresses, but still requires all localisations to fit in 350px, so for my first attempt I decided to remove the width restriction completely.
Assignee: nobody → neil
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #525352 - Flags: review?(iann_bugzilla)
Attached patch Possible patch (obsolete) — Splinter Review
Or we could work around the problem by wrapping the status text.
Attachment #525353 - Flags: review?(iann_bugzilla)
(In reply to comment #5)
> Created attachment 525353 [details] [diff] [review]
> Possible patch
> 
> Or we could work around the problem by wrapping the status text.

This would be a better option if the width was made bigger (but not removed completely) and the status text wrapped.
Increased width with wrap option.
Attachment #525352 - Attachment is obsolete: true
Attachment #525353 - Attachment is obsolete: true
Attachment #525352 - Flags: review?(iann_bugzilla)
Attachment #525353 - Flags: review?(iann_bugzilla)
Attachment #525649 - Flags: review?(iann_bugzilla)
Attachment #525649 - Flags: review?(iann_bugzilla) → review+
Pushed changeset 735f927cf7eb to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #525649 - Attachment description: Proposed patch → Proposed patch [Checked in: Comment 8]
Target Milestone: --- → seamonkey2.1final
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: