648844 - localized text in extension download tooltip doesn't fit

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Konstantin Zemlyak]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0pre) Gecko/20110408 Firefox/4.0pre SeaMonkey/2.1b3

When installing add-on there is a tooltip with progress bar and action button, with explanation text below. On localized version text doesn't fit and gets shortened even though the whole window is supposed to be auto-sized so it shall fit completely.

Reproducible: Always

Steps to Reproduce:
1. try to install some addon while using non-english locale
2. extension tooltip appears with progress info, which gets shortened instead of fitting

Actual Results:  
Label content is shortened with "text..."

Expected Results:  
Tooltip window should get wider to make whole content of the label fit inside (screen width permitting).

Happens to me on russian locale. Other locales that have translations longer than original are probably affected too.

Comment 1

[Konstantin Zemlyak]

Attachment: screenshot of affected window

Comment 2

[[e-mail]]

Ah, I thought that it would have stretched the doorhanger to fit the label.

Could you attach a screenshot of the equivalent Firefox doorhanger to compare?

Comment 3

[Konstantin Zemlyak]

Attachment: Same window in FF4

Firefox resizes window properly.

Comment 4

[[e-mail]]

Attachment: Possible patch

After looking more closely, it actually happens in en-US too, but my internet connection is fast enough that it flashes by and I hadn't noticed before.

The problem is that the description is normally limited to 248px to make it wrap. Firefox works around this by fixing the width at 350px, which does avoid the problem of the popup resizing as it progresses, but still requires all localisations to fit in 350px, so for my first attempt I decided to remove the width restriction completely.

Comment 5

[[e-mail]]

Attachment: Possible patch

Or we could work around the problem by wrapping the status text.

Comment 6

[Ian Neal]

(In reply to comment #5)
> Created attachment 525353 [details] [diff] [review]
> Possible patch
> 
> Or we could work around the problem by wrapping the status text.

This would be a better option if the width was made bigger (but not removed completely) and the status text wrapped.

Comment 7

[[e-mail]]

Attachment: Proposed patch [Checked in: Comment 8]

Increased width with wrap option.

Comment 8

[[e-mail]]

Pushed changeset 735f927cf7eb to comm-central.