Closed Bug 648865 Opened 10 years ago Closed 10 years ago

Remove WINCE code from js/src/assember/*

Categories

(Core :: JavaScript Engine, defect)

All
Windows CE
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla6

People

(Reporter: emorley, Assigned: emorley)

References

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file, 1 obsolete file)

Bug 647389 removed WINCE/WINMO code from most of spidermonkey. However, it was requested that some parts of the patch be broken out into separate bugs, since they covered code from upstream sources.

From bug 647389 comment 37:

> >   - js/src/assembler is shared or stolen code too, but I don't know the
> >     policy there. Maybe we've forked it. Paul, ask dmandelin or dvander?
> 
> File a follow-on, submit the subset of the patch in js/src/assembler/ and ask
> cdleary for a review (This code originally landed in cdleary's Yarr patch, and
> it's unclear if this code came from upstream, in which case we won't delete
> it).
Assignee: general → bmo
Status: NEW → ASSIGNED
Attachment #524953 - Flags: review?(cdleary)
Blocks: 614720
Comment on attachment 524953 [details] [diff] [review]
Patch v1 (based on TM rev 4ace629bb676)

I'm passing review on this over to dmandelin -- I think we want to leave it in to make upstream merge comparisons more trivial, but getting a second opinion sounds like a good idea. :-)
Attachment #524953 - Flags: review?(cdleary) → review?(dmandelin)
(In reply to comment #2)
> ...I think we want to leave it in
> to make upstream merge comparisons more trivial, but getting a second opinion
> sounds like a good idea. :-)

Cool yeah WONTFIX would make more sense if it's still being synced with upstream; thought it worth asking either way, given that the patch had already been created for bug 647389 before I realised :-)
Comment on attachment 524953 [details] [diff] [review]
Patch v1 (based on TM rev 4ace629bb676)

I hear WINCE is dead, so let's take it. It looks very unlikely to cause merge conflicts.
Attachment #524953 - Flags: review?(dmandelin) → review+
Updated to TM tip.
Attachment #524953 - Attachment is obsolete: true
Attachment #527896 - Flags: review+
(In reply to comment #4)
> I hear WINCE is dead, so let's take it. It looks very unlikely to cause merge
> conflicts.

Great, thanks for the review :-)
Keywords: checkin-needed
http://hg.mozilla.org/tracemonkey/rev/3246e3124fe7

Thanks Boris :-)
Keywords: checkin-needed
Whiteboard: [fixed-in-tracemonkey]
http://hg.mozilla.org/mozilla-central/rev/3246e3124fe7
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Thanks Chris :-)
Target Milestone: --- → mozilla6
http://mxr.mozilla.org/mozilla-central/search?string=wince&find=/js/src/assember/
...returns 0 results.

-> Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.