648929 - frequently getting drag.info is null error in tabview.js

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Frank Yan (:fryn)]

Upon selecting a group, I get the following error what seems to be every time:

Error: drag.info is null
Source File: chrome://browser/content/tabview.js
Line: 4118

at the line:
this.add(drag.info.$el, options);
in the method:
this.dropOptions.drop = function GroupItem_dropOptions_drop(event) { ... }

Comment 1

[Frank Yan (:fryn)]

CC'ing mitcho, since he wrote the code.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Do you have an exact STR? I tried to reproduce but couldn't.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Can reproduce now. This happens every time you click on a tab to zoom into it.

Comment 4

[Frank Yan (:fryn)]

(In reply to comment #3)
> This happens every time you click on a tab to zoom into it.

That's actually what I meant. I must have been half-asleep when filing this.
Thanks for investigating and taking this bug. :)

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 525541 [details] [diff] [review]
patch v1

Passed try (kind of):

http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=a2426c7ed09f

Comment 7

[Frank Yan (:fryn)]

(In reply to comment #6)
> Passed try (kind of):
> 
> http://tbpl.mozilla.org/?tree=MozillaTry&pusher=[e-mail]&rev=a2426c7ed09f

Yeah, tryserver results are weird. I'd ignore the Android red though. :P

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 525541 [details] [diff] [review]
patch v1

Nice catch

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch for checkin

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/84b1567baa32

Comment 11

[George Carstoiu]

Verified on Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110421 Firefox/6.0a1