649366 - "About Nightly" dialog pads with (out-of-place) gray on bottom, when maximized or resized

Status: NEW

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. Open a nightly from 4/12 or newer (with 'nightly' branding).
 2. Help | About
 3. Click maximize button on dialog.  Or: resize the dialog to be larger.
    (^ I'm not suggesting that this is a major use case -- I just happened
       to do it accidentally, when trying to hit the close button)

ACTUAL RESULTS: Sleek shiny black content gets padded with a very out-of-place-looking gray color (or some other OS-theme-default color, I imagine).

EXPECTED RESULTS: Pad with black, or something else that fits with the branding better.

In earlier Firefox versions, this wasn't a problem because the bottom 20% of the 'about' dialog was already the same gray color, and so the padding-on-maximize would just extend that region.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of resized dialog in Nightly (eww)

Here's a screenshot of the dialog, after I've resized it to be a bit bigger.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot of dialog in Firefox 4 (nice)

Comment 3

[:Margaret Leibovic]

This is more fundamentally bug 252602, but that's a hard bug to fix because of system limitations. Changing the background color on the window would be a good fix to address this bug.

Comment 4

[:Margaret Leibovic]

Attachment: patch

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I think linux has no default -moz-appearance, right? I could only find one for pinstripe. Since it's the only platform where no-resize is broken, I think you can omit the -moz-appearance: none?

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 525535 [details] [diff] [review]
patch

I just tested this patch in a mozilla-central debug build on Ubuntu 10.10 x86_64, and it didn't seem to affect the "About Nightly" appearance for me at all.  (I clobbered my objdir just to make sure I wasn't missing a rebuild of something, and it still looks the same.)

Perhaps I'm missing something, but there might be more that needs doing here...

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Patch works for me on Ubuntu 10.04 (with the default darkish theme?). dholbert, are you sure you applied it correctly? You only need to rebuild browser/.

(I missed the -moz-appearance in global.css - the -moz-appearance: none is indeed needed.)

Comment 8

[Daniel Holbert [:dholbert]]

> dholbert, are you sure you applied it correctly?

Yup, I'm sure.  I just verified with a completely fresh build on a different machine (x86 this time) running Ubuntu 10.10, with the default theme ("Ambiance").  Using up-to-date m-c + this bug's patch. Still behaves exactly the same as the screenshot from comment 1.

Maybe Ubuntu 10.04 & 10.10 differ in a way that comes into play here?

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 525535 [details] [diff] [review]
patch

This seems quite wrong for MOZ_OFFICIAL_BRANDING.

Why is the black background currently being set on #aboutDialogContainer rather than #aboutDialog?

Comment 10

[:Margaret Leibovic]

This patch will be broken when the patch for bug 652306 lands, so it needs to change anyway.

(In reply to comment #9)
> This seems quite wrong for MOZ_OFFICIAL_BRANDING.

Very good point :)

> Why is the black background currently being set on #aboutDialogContainer rather
> than #aboutDialog?

I believe I set the background on #aboutDialogContainer to avoid needing to use -moz-appearance: none; on the window. Normally the background color doesn't matter because the background image fills the entire space, but I specified a background color because long localized strings for the channel switcher can cause the box to stretch wider than the image.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 13

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 14

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

No assignee, updating the status.