Update about window to use new background images

VERIFIED FIXED in Firefox 5

Status

()

defect
VERIFIED FIXED
8 years ago
6 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Depends on 2 bugs)

Trunk
Firefox 5
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [bugday-20110513] )

Attachments

(4 attachments, 2 obsolete attachments)

Assignee

Description

8 years ago
Martell made some awesome new images for the about window, and this is where we will implement them!

Comment 1

8 years ago
Posted image About Mockup
- revised background image mockup

Comment 2

8 years ago

Comment 3

8 years ago

Comment 4

8 years ago
enjoy! :)

Comment 5

8 years ago
Looks really nice. Voting!

Comment 6

8 years ago
Wow, those are beautiful!
Assignee

Updated

8 years ago
Depends on: 648368
Assignee

Comment 7

8 years ago
Posted patch WIP patch (obsolete) — Splinter Review
For this to work in RTL, I'll need horizontally flipped images. Sean, could you make those for me?

Comment 8

8 years ago
The once concern with that is with the current layout we'd axe the sun rising on the globe, the aurora.

could we simply change the justification and not the layout?
Assignee

Comment 9

8 years ago
(In reply to comment #8)
> could we simply change the justification and not the layout?

That will require more changes on my end, but I think that's a smarter choice. I'll do that.
Dark backgrounds of the about window look cool but do not match with the appearance of other programs on Windows including Firefox. Please give this a thought.
That's not a valid reason to not do it, a lot of software has custom about dialogs, especially on Windows.  Consistency with the OS is a good point, where it matters.
These are special windows for special builds, at most only ~1% of our user base will ever see one of them.
Assignee

Comment 13

8 years ago
Posted patch patch (obsolete) — Splinter Review
I still need to test on Windows/Linux, but it looks good on OSX.
Attachment #524765 - Attachment is obsolete: true
Attachment #525088 - Flags: review?(gavin.sharp)
Assignee

Comment 14

8 years ago
Posted patch patch v2Splinter Review
Updated to fix extra space at the bottom of #bottomBox in nightly/aurora builds.
Attachment #525088 - Attachment is obsolete: true
Attachment #525088 - Flags: review?(gavin.sharp)
Attachment #525138 - Flags: review?(gavin.sharp)
Comment on attachment 525138 [details] [diff] [review]
patch v2

>diff --git a/browser/base/content/aboutDialog.css b/browser/base/content/aboutDialog.css

>+/* we assume trademark text only appears in offical builds */
>+%ifdef MOZ_OFFICIAL_BRANDING  
> #trademark {

Double space at the end of that #ifdef line was breaking things. I fixed that and pushed this:

https://hg.mozilla.org/mozilla-central/rev/f9c427576ca9
Attachment #525138 - Flags: review?(gavin.sharp) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox4.2
(In reply to comment #16)
> Mockups looks awesome!
> Good job guys! :)

So do the latest hourly builds. :D
Just one question - why isn't the program icon updated in the latest 'Nightly' hourly, from the one in Minefield?

Comment 18

8 years ago
mozilla-central-win32/1302583634

-> Win7 Taskbar and firefox.exe still show the old Minefield icon.
http://forums.mozillazine.org/viewtopic.php?p=10678991#p10678991
Assignee

Comment 19

8 years ago
(In reply to comment #17)
(In reply to comment #18)

Those issues would be related to bug 648368, not this bug.
Depends on: 649367
Depends on: 649366
Target Milestone: Firefox5 → Firefox 5
Depends on: 649605

Updated

8 years ago
Depends on: 649732
verified:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110512 Firefox/6.0a1 ID:20110512030634
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0a2) Gecko/20110510 Firefox/5.0a2
Status: RESOLVED → VERIFIED
Whiteboard: [bugday-20110513]
No longer depends on: 649732
You need to log in before you can comment on or make changes to this bug.