648362 - Update about window to use new background images

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[:Margaret Leibovic]

Martell made some awesome new images for the about window, and this is where we will implement them!

Comment 1

[Sean Martell]

Attachment: About Mockup

- revised background image mockup

Comment 2

[Sean Martell]

Attachment: Aurora about background

Comment 3

[Sean Martell]

Attachment: Nightly about background

Comment 4

[Sean Martell]

enjoy! :)

Comment 5

[George Carstoiu]

Looks really nice. Voting!

Comment 6

[u88484]

Wow, those are beautiful!

Comment 7

[:Margaret Leibovic]

Attachment: WIP patch

For this to work in RTL, I'll need horizontally flipped images. Sean, could you make those for me?

Comment 8

[Sean Martell]

The once concern with that is with the current layout we'd axe the sun rising on the globe, the aurora.

could we simply change the justification and not the layout?

Comment 9

[:Margaret Leibovic]

(In reply to comment #8)
> could we simply change the justification and not the layout?

That will require more changes on my end, but I think that's a smarter choice. I'll do that.

Comment 10

[Siddhartha Dugar [:sdrocking]]

Dark backgrounds of the about window look cool but do not match with the appearance of other programs on Windows including Firefox. Please give this a thought.

Comment 11

[Marco Bonardo [:mak]]

That's not a valid reason to not do it, a lot of software has custom about dialogs, especially on Windows.  Consistency with the OS is a good point, where it matters.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

These are special windows for special builds, at most only ~1% of our user base will ever see one of them.

Comment 13

[:Margaret Leibovic]

Attachment: patch

I still need to test on Windows/Linux, but it looks good on OSX.

Comment 14

[:Margaret Leibovic]

Attachment: patch v2

Updated to fix extra space at the bottom of #bottomBox in nightly/aurora builds.

Comment 15

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 525138 [details] [diff] [review]
patch v2

>diff --git a/browser/base/content/aboutDialog.css b/browser/base/content/aboutDialog.css

>+/* we assume trademark text only appears in offical builds */
>+%ifdef MOZ_OFFICIAL_BRANDING  
> #trademark {

Double space at the end of that #ifdef line was breaking things. I fixed that and pushed this:

https://hg.mozilla.org/mozilla-central/rev/f9c427576ca9

Comment 16

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Mockups looks awesome!
Good job guys! :)

Comment 17

[Siddhartha Dugar [:sdrocking]]

(In reply to comment #16)
> Mockups looks awesome!
> Good job guys! :)

So do the latest hourly builds. :D
Just one question - why isn't the program icon updated in the latest 'Nightly' hourly, from the one in Minefield?

Comment 18

[gixxpunk]

mozilla-central-win32/1302583634

-> Win7 Taskbar and firefox.exe still show the old Minefield icon.
http://forums.mozillazine.org/viewtopic.php?p=10678991#p10678991

Comment 19

[:Margaret Leibovic]

(In reply to comment #17)
(In reply to comment #18)

Those issues would be related to bug 648368, not this bug.

Comment 20

[Stephanie Daugherty [:sdaugherty]]

verified:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0a1) Gecko/20110512 Firefox/6.0a1 ID:20110512030634
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:5.0a2) Gecko/20110510 Firefox/5.0a2