implement moz-icon android support

VERIFIED FIXED in Firefox 7

Status

()

Core
Widget: Android
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: blassey, Assigned: alexp)

Tracking

(Blocks: 1 bug, {verified-aurora})

Trunk
mozilla7
ARM
Android
verified-aurora
Points:
---

Firefox Tracking Flags

(firefox7 fixed, fennec7+)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Reporter)

Updated

6 years ago
OS: Linux → Android
Hardware: x86_64 → ARM
(Reporter)

Updated

6 years ago
Whiteboard: [fennec-7]
(Reporter)

Updated

6 years ago
Duplicate of this bug: 611334
(Reporter)

Updated

6 years ago
Duplicate of this bug: 518361
tracking-fennec: ? → 7+
(Reporter)

Updated

6 years ago
Whiteboard: [fennec-7]
(Assignee)

Comment 3

6 years ago
Created attachment 537625 [details] [diff] [review]
[WIP] Stub decoder

Just an empty decoder module to see if it's hooked up properly.
(Assignee)

Comment 4

6 years ago
Created attachment 537898 [details] [diff] [review]
[WIP] libxul-config.mk change

One more bit, which actually enables the icon decoder component for Android.
(Assignee)

Comment 5

6 years ago
Created attachment 539368 [details] [diff] [review]
Fix

The patch includes
- Java function to get the icon for a specific file extension
- AndroidBridge and IPC bits to call the Java code
- nsIconChannel decoder implementation for Android in libpr0n
- makefiles/config changes to use a proper theme and include the new decoder code in Android build
Attachment #537625 - Attachment is obsolete: true
Attachment #537898 - Attachment is obsolete: true
Attachment #539368 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Comment on attachment 539368 [details] [diff] [review]
Fix

Review of attachment 539368 [details] [diff] [review]:
-----------------------------------------------------------------

r=blassey assuming the theme change isn't required

::: configure.in
@@ -4850,5 @@
>          NSS_DISABLE_DBM=1
>          USE_ARM_KUSER=1
>          MOZ_INSTALLER=
>          NECKO_WIFI=
> -        MOZ_THEME_FASTSTRIPE=1

I don't think this change is needed, can you confirm and remove? or explain why its required.
Attachment #539368 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 7

6 years ago
(In reply to comment #6)
> ::: configure.in
...
> > -        MOZ_THEME_FASTSTRIPE=1
> 
> I don't think this change is needed, can you confirm and remove? or explain
> why its required.

I've double-checked that (actually triple-checked :)). It seems like it is not actually required. I tried different things, and was consistently getting the issues with this flag enabled. Apparently it was affected by something else. For some reason the changes in the module code and makefiles are not always picked up by the build, I had to remove the binary files manually to build properly.
Anyway, I'm submitting a patch without this change.
(Assignee)

Comment 8

6 years ago
Created attachment 539961 [details] [diff] [review]
Fix v2

Updated patch.
r=blassey
Attachment #539368 - Attachment is obsolete: true
Attachment #539961 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/12a9a11b2cbd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
status-firefox7: --- → fixed
Verified Fixed

Nightly:
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110726 Firefox/8.0a1 Fennec/8.0a1

Aurora:
Mozila/5.0 (Android; Linux armv7l; rv:7.0a2) Gecko/20110726 Firefox/7.0a2 Fennec/7.0a2
Status: RESOLVED → VERIFIED
Keywords: verified-aurora
do we have tests for this?
Flags: in-testsuite?
Flags: in-litmus?(aaron.train)

Updated

6 years ago
Flags: in-litmus?(aaron.train)

Updated

5 years ago
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.