Closed Bug 649599 Opened 9 years ago Closed 8 years ago

Make getAttributeNS return null for absent attributes

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

()

Details

(Keywords: dev-doc-complete, Whiteboard: [wdc])

Attachments

(2 files)

Attached patch Patch v1Splinter Review
No description provided.
Attachment #525645 - Flags: review?(peterv)
Flags: in-testsuite+
Is this web-compatible?  I thought browsers had converged on getAttribute and getAttributeNS returning "" and the DOM spec just hadn't been errata'd accordingly (and that Web DOM Core was going to make that change).
Almost. Browsers have converged on getAttribute returning null, while DOM specs required the empty string. (<http://www.w3.org/TR/DOM-Level-3-Core/core.html#ID-666EE0F9>.) IIRC, there was no consensus either way for getAttributeNS, but it seems to make more sense to have them consistent.
Oh, ok.  so I just had it backwards.  Gotcha.
Duplicate of this bug: 382786
Comment on attachment 525645 [details] [diff] [review]
Patch v1

How woudl you feel about doing this in GetAttr instead? There shouldn't be too many implementations of that.
That works for me. (I understood void strings to be frowned upon except for passing to JS directly, though.)
Attached patch Patch v2Splinter Review
Attachment #525645 - Attachment is obsolete: true
Attachment #525645 - Flags: review?(peterv)
Attachment #586800 - Flags: review?(peterv)
Comment on attachment 586800 [details] [diff] [review]
Patch v2

Yeah, no. This makes reflected attributes return null, and that breaks the web.
Attachment #586800 - Flags: review?(peterv) → review-
Attachment #525645 - Attachment is obsolete: false
Attachment #525645 - Flags: review?(peterv)
Attachment #525645 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/1eab6ae9e060
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Whiteboard: [wdc][needs review] → [wdc]
Target Milestone: --- → mozilla13
Docs updated:

https://developer.mozilla.org/en/DOM/element.getAttributeNS

Mentioned on Firefox 13 for developers.
Depends on: 767353
You need to log in before you can comment on or make changes to this bug.