Closed Bug 767353 Opened 10 years ago Closed 10 years ago
Empty link properties for non-text links since seamonkey 2
Seamonkey since v2.10 has empty link properties for non-text links (2.9.1 works, but 2.10b1 does not). Text links work fine. Steps to reproduce: 1. Open http://www.seamonkey-project.org/ 2. Right-click on the top-left logo and select "Properties" 3. See image properties, but NO link properties. Attached screenshot should explain the issue. It's not limited to images. Link properties of "Recommended" links on the right side of http://youtube.com/ are shown empty too.
Regression from core bug 649599. I guess we'd better audit all calls to GetAttributeNS...
Confirming on trunk User agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/16.0 Firefox/16.0a1 SeaMonkey/2.13a1 Build identifier: 20120619003009
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Linux → All
Hardware: x86 → All
Version: SeaMonkey 2.11 Branch → Trunk
Whiteboard: [good first bug][mentor=Neil][lang=js][level=beginner]
(In reply to Philip Chee from comment #3) > > Regression from core bug 649599. I guess we'd better audit all calls to GetAttributeNS... > I just checked /suite/ that appears to be the only occurrence of depending on > GetAttributeNS() returning "" for no attribute. Don't worry, I didn't spot switch (elem.getAttributeNS(XLinkNS,"show")) either.
Attached patch fixed the problem for me.
Comment on attachment 638812 [details] [diff] [review] Suggested patch [Approval Request Comment] Regression caused by (bug #): 649599 User impact if declined: Wrong properties for links containing other elements Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): Low String changes made by this patch: None
Assignee: nobody → sergemp
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 638812 [details] [diff] [review] Suggested patch a=me regression fix.
Pushed comm-aurora changeset d977cf0ce73b. Pushed comm-beta changeset bd4a603a168e. I messed up the attribution on the c-a changeset though. Sorry about that.
You need to log in before you can comment on or make changes to this bug.